Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2277363002: [stubs] Consolidate TryToName implementation (Closed)

Created:
4 years, 3 months ago by Jakob Kummerow
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Toon Verwaest
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Consolidate TryToName implementation This extends TryToName by HeapNumber-to-intptr support and cached array index retrieval from non-internalized strings, and uses it in the KeyedLoadIC_Generic stub. Bonus: avoid needless movsxlq on x64 in LoadFixed{,Double}ArrayElement helpers by introducing INTPTR_PARAMETER mode. Committed: https://crrev.com/71dfcbacc2277d890d914b292f5725a6f3f1a5cf Cr-Commit-Position: refs/heads/master@{#39217}

Patch Set 1 #

Total comments: 19

Patch Set 2 : rebased #

Patch Set 3 : addressed comments #

Patch Set 4 : rebased #

Patch Set 5 : fix strings of uncacheable indices #

Total comments: 1

Patch Set 6 : reword comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -142 lines) Patch
M src/builtins/builtins-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stub-assembler.h View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 4 5 27 chunks +102 lines, -128 lines 0 comments Download
M src/compiler/code-assembler.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 2 3 4 4 chunks +38 lines, -5 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
Jakob Kummerow
Here is the promised follow-up. PTAL.
4 years, 3 months ago (2016-08-25 16:59:26 UTC) #2
Jakob Kummerow
Redirecting to Igor. Please review at your convenience :-)
4 years, 3 months ago (2016-09-01 08:44:34 UTC) #5
Igor Sheludko
First round of comments. https://codereview.chromium.org/2277363002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2277363002/diff/1/src/code-stub-assembler.cc#newcode2274 src/code-stub-assembler.cc:2274: Int32GreaterThan(key_instance_type, Int32Constant(LAST_UNIQUE_NAME_TYPE)), It looks like ...
4 years, 3 months ago (2016-09-01 14:31:31 UTC) #6
Igor Sheludko
https://codereview.chromium.org/2277363002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2277363002/diff/1/src/code-stub-assembler.cc#newcode2280 src/code-stub-assembler.cc:2280: GotoIf(Word32Equal(contains_index, Int32Constant(0)), &if_hascachedindex); On 2016/09/01 14:31:30, Igor Sheludko wrote: ...
4 years, 3 months ago (2016-09-01 15:52:17 UTC) #7
Jakob Kummerow
PTAL. https://codereview.chromium.org/2277363002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2277363002/diff/1/src/code-stub-assembler.cc#newcode2274 src/code-stub-assembler.cc:2274: Int32GreaterThan(key_instance_type, Int32Constant(LAST_UNIQUE_NAME_TYPE)), On 2016/09/01 14:31:30, Igor Sheludko wrote: ...
4 years, 3 months ago (2016-09-05 13:15:54 UTC) #8
Igor Sheludko
lgtm
4 years, 3 months ago (2016-09-05 16:08:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277363002/60001
4 years, 3 months ago (2016-09-06 13:57:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23415)
4 years, 3 months ago (2016-09-06 14:01:36 UTC) #15
Michael Starzinger
LGTM (rubber-stamp on "compiler", didn't look at the rest).
4 years, 3 months ago (2016-09-06 14:04:32 UTC) #17
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/2277363002/diff/80001/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2277363002/diff/80001/src/code-stub-assembler.cc#newcode2283 src/code-stub-assembler.cc:2283: // No cached array index. ...
4 years, 3 months ago (2016-09-06 15:35:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277363002/100001
4 years, 3 months ago (2016-09-06 15:46:43 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-09-06 16:17:13 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 16:18:21 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/71dfcbacc2277d890d914b292f5725a6f3f1a5cf
Cr-Commit-Position: refs/heads/master@{#39217}

Powered by Google App Engine
This is Rietveld 408576698