Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2283003002: Remove unneeded scoped_refptr<>::get on method bind (Closed)

Created:
4 years, 3 months ago by tzik
Modified:
4 years, 3 months ago
Reviewers:
dcheng
CC:
chromium-reviews, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded scoped_refptr<>::get on method bind This CL adds a clang tool to rewrite unneeded scoped_refptr<>::get, and applies it to //base. To build and apply this tool, run below: $ ./tools/clang/scripts/update.py --force-local-build --without-android --tools base_bind_rewriter $ ./tools/clang/scripts/run_tool.py --regenerate-compdb base_bind_rewriters out/Release base Committed: https://crrev.com/0f0d8e8105e119dabef9ed66c1dcba1da43ee834 Cr-Commit-Position: refs/heads/master@{#415616}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : clean up #

Total comments: 5

Patch Set 4 : update #

Total comments: 4

Patch Set 5 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -19 lines) Patch
M base/message_loop/message_loop_test.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/message_loop/message_pump_glib_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A tools/clang/base_bind_rewriters/BaseBindRewriters.cpp View 1 2 3 4 1 chunk +112 lines, -0 lines 0 comments Download
A + tools/clang/base_bind_rewriters/CMakeLists.txt View 2 chunks +4 lines, -4 lines 0 comments Download
A tools/clang/base_bind_rewriters/tests/test-expected.cc View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A tools/clang/base_bind_rewriters/tests/test-original.cc View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (21 generated)
tzik
PTAL.
4 years, 3 months ago (2016-08-28 18:09:08 UTC) #13
dcheng
https://codereview.chromium.org/2283003002/diff/40001/tools/clang/base_bind_rewriters/BaseBindRewriters.cpp File tools/clang/base_bind_rewriters/BaseBindRewriters.cpp (right): https://codereview.chromium.org/2283003002/diff/40001/tools/clang/base_bind_rewriters/BaseBindRewriters.cpp#newcode3 tools/clang/base_bind_rewriters/BaseBindRewriters.cpp:3: // found in the LICENSE file. Let's document what ...
4 years, 3 months ago (2016-08-29 20:04:09 UTC) #16
tzik
https://codereview.chromium.org/2283003002/diff/40001/tools/clang/base_bind_rewriters/BaseBindRewriters.cpp File tools/clang/base_bind_rewriters/BaseBindRewriters.cpp (right): https://codereview.chromium.org/2283003002/diff/40001/tools/clang/base_bind_rewriters/BaseBindRewriters.cpp#newcode3 tools/clang/base_bind_rewriters/BaseBindRewriters.cpp:3: // found in the LICENSE file. On 2016/08/29 20:04:09, ...
4 years, 3 months ago (2016-08-30 07:40:50 UTC) #19
dcheng
https://codereview.chromium.org/2283003002/diff/60001/tools/clang/base_bind_rewriters/BaseBindRewriters.cpp File tools/clang/base_bind_rewriters/BaseBindRewriters.cpp (right): https://codereview.chromium.org/2283003002/diff/60001/tools/clang/base_bind_rewriters/BaseBindRewriters.cpp#newcode67 tools/clang/base_bind_rewriters/BaseBindRewriters.cpp:67: auto* member = llvm::dyn_cast<clang::MemberExpr>(target->getCallee()); Nit: use cast<> here, since ...
4 years, 3 months ago (2016-08-31 06:14:44 UTC) #22
tzik
https://codereview.chromium.org/2283003002/diff/60001/tools/clang/base_bind_rewriters/BaseBindRewriters.cpp File tools/clang/base_bind_rewriters/BaseBindRewriters.cpp (right): https://codereview.chromium.org/2283003002/diff/60001/tools/clang/base_bind_rewriters/BaseBindRewriters.cpp#newcode67 tools/clang/base_bind_rewriters/BaseBindRewriters.cpp:67: auto* member = llvm::dyn_cast<clang::MemberExpr>(target->getCallee()); On 2016/08/31 06:14:44, dcheng wrote: ...
4 years, 3 months ago (2016-08-31 09:06:43 UTC) #23
dcheng
lgtm
4 years, 3 months ago (2016-08-31 09:25:00 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283003002/80001
4 years, 3 months ago (2016-08-31 11:09:15 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-31 12:24:11 UTC) #28
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 12:27:54 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0f0d8e8105e119dabef9ed66c1dcba1da43ee834
Cr-Commit-Position: refs/heads/master@{#415616}

Powered by Google App Engine
This is Rietveld 408576698