Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2317563002: Move CallbackBase::polymorphic_invoke_ into BindStateBase (Closed)

Created:
4 years, 3 months ago by tzik
Modified:
4 years, 3 months ago
Reviewers:
Yuta Kitamura, dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CallbackBase::polymorphic_invoke_ into BindStateBase Each Callback instance had its own polymorphic_invoke, that doubles the size of Callback, and its initialization gains 40kB of the stripped binary size of Chrome on Linux. This CL moves polymorphic_invoke_ into BindStateBase to share it among Callback. Committed: https://crrev.com/1886c27824eda740f5b50f858ff987ed557b6166 Cr-Commit-Position: refs/heads/master@{#417197}

Patch Set 1 #

Patch Set 2 : -private #

Patch Set 3 : '' #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -39 lines) Patch
M base/bind.h View 1 2 1 chunk +12 lines, -4 lines 0 comments Download
M base/bind_internal.h View 1 chunk +4 lines, -2 lines 0 comments Download
M base/callback.h View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M base/callback_internal.h View 1 2 3 chunks +19 lines, -11 lines 0 comments Download
M base/callback_internal.cc View 4 chunks +1 line, -8 lines 0 comments Download
M base/callback_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (19 generated)
tzik
PTAL
4 years, 3 months ago (2016-09-06 07:38:45 UTC) #5
dcheng
lgtm
4 years, 3 months ago (2016-09-06 21:43:10 UTC) #13
Yuta Kitamura
lgtm
4 years, 3 months ago (2016-09-07 08:01:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317563002/80001
4 years, 3 months ago (2016-09-08 03:46:52 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-08 05:45:57 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 05:48:59 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1886c27824eda740f5b50f858ff987ed557b6166
Cr-Commit-Position: refs/heads/master@{#417197}

Powered by Google App Engine
This is Rietveld 408576698