Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2322963004: Clean up formatting, rework run wrapper script to not use globals. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
nednguyen
Target Ref:
refs/heads/master
Project:
typ
Visibility:
Public.

Description

Clean up formatting, rework run wrapper script to not use globals. (No functional changes expected). R=nednguyen@google.com BUG=

Patch Set 1 #

Patch Set 2 : fix typos, lint errors #

Total comments: 2

Patch Set 3 : update w/ review feedback, lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -94 lines) Patch
M run View 1 2 1 chunk +83 lines, -88 lines 0 comments Download
M setup.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/cov.py View 1 chunk +1 line, -1 line 0 comments Download
M typ/fakes/test_result_server_fake.py View 1 1 chunk +1 line, -1 line 0 comments Download
M typ/runner.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M typ/tests/main_test.py View 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2201663002 Patch 1

Messages

Total messages: 5 (2 generated)
Dirk Pranke
4 years, 3 months ago (2016-09-09 01:33:15 UTC) #2
nednguyen
lgtm with nits https://codereview.chromium.org/2322963004/diff/40001/run File run (right): https://codereview.chromium.org/2322963004/diff/40001/run#newcode17 run:17: self.repo_dir = os.path.abspath(os.path.dirname(__file__)) should repo_dir, path_to_cov, ...
4 years, 3 months ago (2016-09-09 15:28:53 UTC) #3
Dirk Pranke
4 years, 3 months ago (2016-09-09 18:43:26 UTC) #4 
https://codereview.chromium.org/2322963004/diff/40001/run
File run (right):

https://codereview.chromium.org/2322963004/diff/40001/run#newcode17
run:17: self.repo_dir = os.path.abspath(os.path.dirname(__file__))
On 2016/09/09 15:28:53, nednguyen wrote:
> should repo_dir, path_to_cov, path_to_runner, python be added with prefix "_"
to
> make it clear that they shouldn't be touched by callsites?

Sure, can do.

Powered by Google App Engine
This is Rietveld 408576698