Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2503423006: [asmjs] Flush after printing error message (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asmjs] Flush after printing error message This hopefully avoids multiple error messages appearing on the same line. R=titzer@chromium.org, machenbach@chromium.org BUG=chromium:660016 Committed: https://crrev.com/ae3ca62b6b6caa212887014cbe068a9dcc878e7d Cr-Commit-Position: refs/heads/master@{#41070}

Patch Set 1 #

Patch Set 2 : Even shorter ;) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/asmjs/asm-js.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael Achenbach
lgtm
4 years, 1 month ago (2016-11-17 10:17:11 UTC) #5
Clemens Hammacher
4 years, 1 month ago (2016-11-17 10:17:12 UTC) #6
titzer
lgtm
4 years, 1 month ago (2016-11-17 10:19:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503423006/20001
4 years, 1 month ago (2016-11-17 11:09:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 11:31:57 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:38:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae3ca62b6b6caa212887014cbe068a9dcc878e7d
Cr-Commit-Position: refs/heads/master@{#41070}

Powered by Google App Engine
This is Rietveld 408576698