Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2514253002: Remove support for the linux-precise layout tests port. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke, jeffcarp, ojan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for the linux-precise layout tests port. This CL should remove support for linux-precise port, although it doesn't yet remove all instances of the string "precise", which also occur in various tests. A possible follow-up would be to update these tests to not use the string "precise". This CL also removes all lines that were marked as Skip for Precise, and updates baselines for those tests. BUG=660580 Committed: https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f Cr-Commit-Position: refs/heads/master@{#434000}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Remove TestExpectations lines with Precise #

Patch Set 4 : Update linux baselines #

Patch Set 5 : Update TestExpectations #

Patch Set 6 : Temporarily skip tests that are failing on linux_chromium_rel_ng #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -98 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 5 chunks +18 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/canvas/canvas-composite-video-shadow-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/complex-text-opacity-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/font-fallback-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/international/complex-character-based-fallback-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/international/complex-character-based-fallback-expected.txt View 1 2 3 1 chunk +19 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/international/complex-joining-using-gpos-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/layout-fonts/languages-emoji-rare-glyphs-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-08-b-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-08-b-expected.txt View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/svg/custom/control-points-for-S-and-T-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/transforms/2d/hindi-rotated-expected.png View 1 2 3 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 33 (21 generated)
qyearsley
4 years, 1 month ago (2016-11-20 22:45:18 UTC) #5
Dirk Pranke
lgtm
4 years ago (2016-11-21 23:45:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514253002/20001
4 years ago (2016-11-22 03:28:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/310174)
4 years ago (2016-11-22 03:34:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514253002/60001
4 years ago (2016-11-22 18:37:55 UTC) #18
qyearsley
I've now changed this CL so that it removes all of the "[ Precise ] ...
4 years ago (2016-11-22 18:39:26 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/310672)
4 years ago (2016-11-22 18:46:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514253002/80001
4 years ago (2016-11-22 19:26:03 UTC) #25
qyearsley
On 2016/11/22 at 19:26:03, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years ago (2016-11-22 21:00:14 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514253002/100001
4 years ago (2016-11-22 21:01:01 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-11-22 22:01:23 UTC) #31
commit-bot: I haz the power
4 years ago (2016-11-22 22:04:15 UTC) #33
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f
Cr-Commit-Position: refs/heads/master@{#434000}

Powered by Google App Engine
This is Rietveld 408576698