Chromium Code Reviews

Issue 2584833002: [wasm] Disable trap-if test on windows for now (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Disable trap-if test on windows for now It's failing nondeterministically. Disable trap-if tests on windows until this issue is fixed. R=ahaas@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2584833002 Cr-Commit-Position: refs/heads/master@{#41763} Committed: https://chromium.googlesource.com/v8/v8/+/bb76432fde6cee11f35757786c8ca24e1d8ef2ac

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+4 lines, -0 lines)
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +4 lines, -0 lines 0 comments

Messages

Total messages: 12 (7 generated)
Clemens Hammacher
4 years ago (2016-12-16 12:56:48 UTC) #3
ahaas
lgtm
4 years ago (2016-12-16 13:12:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584833002/1
4 years ago (2016-12-16 14:18:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/bb76432fde6cee11f35757786c8ca24e1d8ef2ac
4 years ago (2016-12-16 14:20:20 UTC) #11
Clemens Hammacher
4 years ago (2016-12-16 15:30:42 UTC) #12
Message was sent while issue was closed.
Reverted in http://crrev.com/2579213004

Powered by Google App Engine