Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2595793002: Run the webkit layout tests under swarming on linux_chromium_rel_ng. (Closed)

Created:
4 years ago by Dirk Pranke
Modified:
3 years, 10 months ago
CC:
chromium-reviews, djd-OOO-Apr2017, jeffcarp, mcgreevy, Paweł Hajdan Jr., mithro
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run the webkit layout tests under swarming on linux_chromium_rel_ng. NOT FOR LANDING - THIS ISN'T STABLE YET AND IS MISSING FUNCTIONALITY. This enables running the layout tests under swarming, in two different ways. In a step called "locally_swarmed_layout_tests", we run the entire suite, using the new `exparchive` isolate command. In another step, called "some_webkit_layout_tests", we run a subset of the layout tests using the normal swarming mechanism. This allows us to exercise both code paths. The current code does not merge the JSON results together from multiple shards, nor does it upload the results to the cloud storage bucket, nor does it get all of the metadata it needs to annotate the results properly, so it's really only useful for testing the state of swarming itself. BUG=524758

Patch Set 1 #

Patch Set 2 : fix local script #

Patch Set 3 : remove the webkit_layout_tests target and bump up the number of shards #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -7 lines) Patch
M BUILD.gn View 1 2 2 chunks +60 lines, -3 lines 1 comment Download
M testing/buildbot/chromium.linux.json View 1 2 2 chunks +23 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +16 lines, -3 lines 2 comments Download
M testing/buildbot/manage.py View 1 chunk +1 line, -1 line 0 comments Download
A testing/scripts/run_isolated_script_test.py View 1 chunk +97 lines, -0 lines 2 comments Download
A testing/scripts/run_locally_swarmed_webkit_layout_tests.py View 1 1 chunk +97 lines, -0 lines 3 comments Download

Messages

Total messages: 9 (4 generated)
Dirk Pranke
3 years, 11 months ago (2017-01-13 00:59:22 UTC) #4
qyearsley
https://codereview.chromium.org/2595793002/diff/40001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2595793002/diff/40001/BUILD.gn#newcode911 BUILD.gn:911: ":webkit_layout_tests", Note, when trying this locally I got a ...
3 years, 11 months ago (2017-01-13 01:09:12 UTC) #5
qyearsley
https://codereview.chromium.org/2595793002/diff/40001/testing/buildbot/gn_isolate_map.pyl File testing/buildbot/gn_isolate_map.pyl (right): https://codereview.chromium.org/2595793002/diff/40001/testing/buildbot/gn_isolate_map.pyl#newcode994 testing/buildbot/gn_isolate_map.pyl:994: "script": "//testing/scripts/run_isolated_script_test.py", On 2017/01/13 at 01:09:11, qyearsley wrote: > ...
3 years, 11 months ago (2017-01-13 01:12:03 UTC) #6
mithro
Hi Dirk, Is this one of the CLs you were working on? Tim 'mithro' Ansell ...
3 years, 10 months ago (2017-01-31 23:51:43 UTC) #8
Dirk Pranke
3 years, 10 months ago (2017-02-01 01:32:51 UTC) #9
Yes, this is the CL.

https://codereview.chromium.org/2595793002/diff/40001/testing/scripts/run_iso...
File testing/scripts/run_isolated_script_test.py (right):

https://codereview.chromium.org/2595793002/diff/40001/testing/scripts/run_iso...
testing/scripts/run_isolated_script_test.py:63: def
_remap_gtest_env_vars(orig_env):
On 2017/01/31 23:51:42, mithro wrote:
> run_webkit_tests.py already supports these GTEST arguments,
> ----
> src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests$ grep -n GTEST
> run_webkit_tests.py
> 549:        if not options.total_shards and 'GTEST_TOTAL_SHARDS' in
> port.host.environ:
> 550:            options.total_shards =
> int(port.host.environ['GTEST_TOTAL_SHARDS']) + 1
> 551:        if not options.shard_index and 'GTEST_SHARD_INDEX' in
> port.host.environ:
> 552:            options.shard_index =
> int(port.host.environ['GTEST_SHARD_INDEX'])
> -----
> 
> I think we should push for everything to understand this environment natively?

I think both maruel@ and I consider the support for these env vars to be a
misfeature, so, that would not be my vote, no :).

https://codereview.chromium.org/2595793002/diff/40001/testing/scripts/run_loc...
File testing/scripts/run_locally_swarmed_webkit_layout_tests.py (right):

https://codereview.chromium.org/2595793002/diff/40001/testing/scripts/run_loc...
testing/scripts/run_locally_swarmed_webkit_layout_tests.py:1: #!/usr/bin/env
python
On 2017/01/31 23:51:42, mithro wrote:
> This is emulating what the recipes code should be doing right?

Correct. This is a transitional script that I was using for testing, but we
don't want this in the long run.

Powered by Google App Engine
This is Rietveld 408576698