Replaced usages of WritingMode to use inline utility functions instead

Replaced usages of WritingMode to use inline utility functions instead

Replaced simple usages of WritingMode to use inline utility functions
instead of the enums directly. This is preparing to rename the values of
WritingMode to match the writing-mode keywords, which are less self-
documenting.

BUG=628043
Committed: https://crrev.com/a5b97bd742ab2fbf7946c15aef175fe72ffaebae
Cr-Commit-Position: refs/heads/master@{#440317}

[sashab, 2016-12-21 05:33:08]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org

[sashab, 2016-12-21 05:33:09]

haraken@ ptal. Decided to go ahead with the plan to make generated ComputedStyle
use the platform enum values where possible, which will involve renaming some of
them to the CSS keywords, e.g. verticalRl, horizontalTb. Let me know whether
you'd like to go ahead with this or would rather I add a mapping function to
ComputedStyle and leave these platform enums as-is.

[haraken, 2016-12-21 05:51:34]

LGTM

[sashab, 2016-12-21 23:29:11]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-12-21 23:29:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 23:32:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 23:32:39]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2016-12-22 00:33:22]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-12-22 00:33:23]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2595833002/#ps20001
(title: "Small fixes")

[commit-bot: I haz the power, 2016-12-22 00:34:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 00:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 00:35:53]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[sashab, 2016-12-22 00:58:28]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-12-22 00:58:28]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2595833002/#ps40001
(title: "Rebase and fixed ::blink with just blink::")

[commit-bot: I haz the power, 2016-12-22 00:58:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 02:39:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482368308392880,
"parent_rev": "9a68972d82466118bf8dcdea6f8d01efdbb0ac91", "commit_rev":
"5d246ca54600b074dda4f0e106fdb8ed20701806"}

[commit-bot: I haz the power, 2016-12-22 02:39:55]

Description was changed from

==========
Replaced usages of WritingMode to use inline utility functions instead

Replaced simple usages of WritingMode to use inline utility functions
instead of the enums directly. This is preparing to rename the values of
WritingMode to match the writing-mode keywords, which are less self-
documenting.

BUG=628043
==========

to

==========
Replaced usages of WritingMode to use inline utility functions instead

Replaced simple usages of WritingMode to use inline utility functions
instead of the enums directly. This is preparing to rename the values of
WritingMode to match the writing-mode keywords, which are less self-
documenting.

BUG=628043

Review-Url: https://codereview.chromium.org/2595833002
==========

[commit-bot: I haz the power, 2016-12-22 02:39:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-22 02:41:53]

Description was changed from

==========
Replaced usages of WritingMode to use inline utility functions instead

Replaced simple usages of WritingMode to use inline utility functions
instead of the enums directly. This is preparing to rename the values of
WritingMode to match the writing-mode keywords, which are less self-
documenting.

BUG=628043

Review-Url: https://codereview.chromium.org/2595833002
==========

to

==========
Replaced usages of WritingMode to use inline utility functions instead

Replaced simple usages of WritingMode to use inline utility functions
instead of the enums directly. This is preparing to rename the values of
WritingMode to match the writing-mode keywords, which are less self-
documenting.

BUG=628043

Committed: https://crrev.com/a5b97bd742ab2fbf7946c15aef175fe72ffaebae
Cr-Commit-Position: refs/heads/master@{#440317}
==========

[commit-bot: I haz the power, 2016-12-22 02:41:54]

Patchset 3 (id:??) landed as
https://crrev.com/a5b97bd742ab2fbf7946c15aef175fe72ffaebae
Cr-Commit-Position: refs/heads/master@{#440317}