Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2625083003: Implement Harmony-style consistent button widths for Collected Cookies. (Closed)

Created:
3 years, 11 months ago by tapted
Modified:
3 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement Harmony-style consistent button widths for Collected Cookies. Adds a member to GridLayout's ColumnSet which imposes a threshold to ignore a column when unifying same sized columns. This also needs to be done for DialogClientView, perhaps via ViewsDelegate, which may be influenced by http://crbug.com/687349. BUG=671820, 610428 TEST=GridLayoutTest.TwoColumnsLinkedSizes Review-Url: https://codereview.chromium.org/2625083003 Cr-Commit-Position: refs/heads/master@{#455281} Committed: https://chromium.googlesource.com/chromium/src/+/81aeead4d36ae4401894ab0b059d9721a30c9521

Patch Set 1 : Start on DialogClientview #

Patch Set 2 : rebase to master #

Patch Set 3 : Add a test #

Patch Set 4 : selfnits #

Total comments: 19

Patch Set 5 : respond to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -37 lines) Patch
M chrome/browser/ui/views/collected_cookies_views.cc View 1 2 3 4 5 chunks +23 lines, -24 lines 0 comments Download
M chrome/browser/ui/views/harmony/harmony_layout_delegate.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/layout_delegate.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/layout_delegate.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/layout/grid_layout.h View 1 2 3 4 3 chunks +10 lines, -1 line 0 comments Download
M ui/views/layout/grid_layout.cc View 1 2 3 4 6 chunks +12 lines, -11 lines 0 comments Download
M ui/views/layout/grid_layout_unittest.cc View 1 2 3 4 2 chunks +74 lines, -1 line 0 comments Download

Messages

Total messages: 26 (19 generated)
tapted
Hi Peter, please take a look
3 years, 9 months ago (2017-03-07 02:04:19 UTC) #10
Peter Kasting
LGTM https://codereview.chromium.org/2625083003/diff/120001/chrome/browser/ui/views/collected_cookies_views.cc File chrome/browser/ui/views/collected_cookies_views.cc (right): https://codereview.chromium.org/2625083003/diff/120001/chrome/browser/ui/views/collected_cookies_views.cc#newcode75 chrome/browser/ui/views/collected_cookies_views.cc:75: using views::GridLayout; Nit: I don't think this saves ...
3 years, 9 months ago (2017-03-07 02:50:37 UTC) #11
tapted
https://codereview.chromium.org/2625083003/diff/120001/chrome/browser/ui/views/collected_cookies_views.cc File chrome/browser/ui/views/collected_cookies_views.cc (right): https://codereview.chromium.org/2625083003/diff/120001/chrome/browser/ui/views/collected_cookies_views.cc#newcode75 chrome/browser/ui/views/collected_cookies_views.cc:75: using views::GridLayout; On 2017/03/07 02:50:37, Peter Kasting wrote: > ...
3 years, 9 months ago (2017-03-07 12:06:41 UTC) #16
Peter Kasting
https://codereview.chromium.org/2625083003/diff/120001/ui/views/layout/grid_layout.cc File ui/views/layout/grid_layout.cc (right): https://codereview.chromium.org/2625083003/diff/120001/ui/views/layout/grid_layout.cc#newcode372 ui/views/layout/grid_layout.cc:372: ColumnSet::ColumnSet(int id) : id_(id), linked_column_size_limit_(INT_MAX) {} On 2017/03/07 12:06:41, ...
3 years, 9 months ago (2017-03-07 21:22:49 UTC) #19
tapted
https://codereview.chromium.org/2625083003/diff/120001/ui/views/layout/grid_layout.cc File ui/views/layout/grid_layout.cc (right): https://codereview.chromium.org/2625083003/diff/120001/ui/views/layout/grid_layout.cc#newcode372 ui/views/layout/grid_layout.cc:372: ColumnSet::ColumnSet(int id) : id_(id), linked_column_size_limit_(INT_MAX) {} On 2017/03/07 21:22:49, ...
3 years, 9 months ago (2017-03-07 22:39:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625083003/140001
3 years, 9 months ago (2017-03-07 23:10:28 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 23:22:38 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/81aeead4d36ae4401894ab0b059d...

Powered by Google App Engine
This is Rietveld 408576698