Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2637013002: CONTINUED Make FrameSelection to hold non-canonicalized positions (Closed)

Created:
3 years, 11 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, Greg Levin, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Continue to http://crrev.com/2680943004 Continue from http://crrev.com/1958093002 After this patch, we will do following: - Rename FrameSelection::selection() to computeVisibleSelectionDerprecated() - Hoist updateStyleAndLayoutIngoringStyleSheet() from computeVisibleSelectionDerprecated() - Interoperabl Selection API; no canonicalization - Multiple range selection - Move VisiblePosition and VisibleSelection to editing/core/commands We use |Selection| to hold DOM positions to support shadow DOM. BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991 [1] https://codereview.chromium.org/1654123002 FrameSelectionTest for caret paiting # Failed tests 2017-01-27T22:10:22 editing/execCommand/indent-button-crash.html (Mac only) interactive_ui_tests LoginTest.GaiaAuthOffline # Failed tests 2017-01-19T16:37 editing/execCommand/indent-paragraphs.html Due by call FrameCaret::setCaretRectDirty() in FrameSelection::commitApperance() FrameSerializerTest.SVGImageDontCrash All/FrameViewTest.SetPaintInvalidationDuringUpdateAllLifecyclePhases/0 All/FrameViewTest.SetPaintInvalidationDuringUpdateAllLifecyclePhases/1 All/FrameViewTest.SetPaintInvalidationOutOfUpdateAllLifecyclePhases/1 All/FrameViewTest.SetPaintInvalidationOutOfUpdateAllLifecyclePhases/0 FrameSerializerTest.XMLDeclaration FrameSelectionTest.InvalidatePreviousCaretAfterRemovingLastCharacter WebMeaningfulLayoutsTest.NoOverflowInIncrementVisuallyNonEmptyPixelCount # Failed tests 2017-01-18T21:32:44 editing/execCommand/indent-paragraphs.html (Mac) fast/dom/shadow/selection-in-nested-shadow.html paint/invalidation/invalidate-caret-before-text-node-update.html shapedetection/detection-HTMLVideoElement.html BrowserNavigatorTest.ReuseRVHWithWebUI -> We should stop caret time when setCaretVisiblity(Hidden) # Failed tests 2017-01-17T12:36:24 FrameSelectionTest.InvalidatePreviousCaretAfterRemovingLastCharacter CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 : 2017-01-17T10:24:55 #

Patch Set 2 : 2017-01-18T18:15:31 #

Patch Set 3 : 2017-01-18T19:40:53 #

Patch Set 4 : 2017-01-19T14:48:53 #

Patch Set 5 : 2017-01-19T17:52:44 #

Patch Set 6 : 2017-01-19T18:55:24 #

Patch Set 7 : 2017-01-20T15:38:54 #

Patch Set 8 : 2017-01-20T17:26:10 #

Patch Set 9 : 2017-01-20T18:57:56 #

Patch Set 10 : 2017-01-23T14:05:38 #

Patch Set 11 : 2017-01-24T19:44:24 #

Patch Set 12 : 2017-01-26T19:46:52 #

Patch Set 13 : 2017-01-27T15:36:33 #

Patch Set 14 : 2017-01-27T19:11:07 #

Patch Set 15 : 2017-01-27T19:40:53 #

Patch Set 16 : 2017-01-27T22:12:57 #

Patch Set 17 : 2017-02-06T14:16:17 #

Patch Set 18 : 2017-02-06T15:41:00 #

Patch Set 19 : 2017-02-06T18:18:52 #

Patch Set 20 : 2017-02-08T14:27:48 #

Patch Set 21 : 2017-02-08T16:38:40 #

Patch Set 22 : 2017-02-08T18:56:19 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -526 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/execCommand/crash-indenting-list-item.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-list.html View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/indent-button-crash.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/indent-button-crash-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/execCommand/remove_format_and_extract_contents.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/character-data-mutation.html View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/document-mutation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_details_crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_iframe_crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/selection_remove_children.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/style/justify-left-crash.html View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/undo/redo-selection-modify-crash.html View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/delete-contents.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/selection-in-nested-shadow.html View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dynamic/move-node-with-selection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/drag_and_drop_into_removed_on_focus.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/images/element-gcd-while-generating-alt-content-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/foreignObject/viewport-foreignobject-crash-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CharacterData.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 5 chunks +13 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 10 chunks +8 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 19 chunks +204 lines, -280 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +47 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +200 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 125 (125 generated)
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-17 01:27:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/1
3 years, 11 months ago (2017-01-17 01:28:02 UTC) #2
yosin_UTC9
Description was changed from ========== 2017-01-17T10:24:55 2017-01-16T20:04:08 BUG= ========== to ========== Continue from http://crrev.com/1958093002 BUG=139552, ...
3 years, 11 months ago (2017-01-17 01:30:02 UTC) #3
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991 ...
3 years, 11 months ago (2017-01-17 01:30:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-17 02:13:12 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/101189)
3 years, 11 months ago (2017-01-17 02:13:13 UTC) #6
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 11 months ago (2017-01-17 03:37:04 UTC) #7
yosin_UTC9
Patchset #2 (id:20001) has been deleted
3 years, 11 months ago (2017-01-17 04:01:24 UTC) #8
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 11 months ago (2017-01-17 07:03:53 UTC) #9
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 11 months ago (2017-01-17 07:12:51 UTC) #10
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-18 09:17:32 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/40001
3 years, 11 months ago (2017-01-18 09:17:48 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-18 10:20:32 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/214963)
3 years, 11 months ago (2017-01-18 10:20:33 UTC) #14
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-18 10:42:11 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/60001
3 years, 11 months ago (2017-01-18 10:42:26 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-18 11:27:32 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/215001)
3 years, 11 months ago (2017-01-18 11:27:33 UTC) #18
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 11 months ago (2017-01-18 12:33:03 UTC) #19
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 11 months ago (2017-01-18 12:34:56 UTC) #20
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-19 05:50:20 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/80001
3 years, 11 months ago (2017-01-19 05:50:43 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-19 06:33:27 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/102976)
3 years, 11 months ago (2017-01-19 06:33:28 UTC) #24
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 11 months ago (2017-01-19 07:37:51 UTC) #25
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-19 08:54:12 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/100001
3 years, 11 months ago (2017-01-19 08:54:30 UTC) #27
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 11 months ago (2017-01-19 09:20:18 UTC) #28
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-19 09:39:00 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/120001
3 years, 11 months ago (2017-01-19 09:39:13 UTC) #30
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-19 09:57:30 UTC) #31
yosin_UTC9
Patchset #6 (id:120001) has been deleted
3 years, 11 months ago (2017-01-19 09:57:40 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/140001
3 years, 11 months ago (2017-01-19 09:57:44 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-19 10:41:26 UTC) #34
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/103087)
3 years, 11 months ago (2017-01-19 10:41:28 UTC) #35
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-20 06:40:26 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/160001
3 years, 11 months ago (2017-01-20 06:40:38 UTC) #37
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-20 07:28:14 UTC) #38
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/103915)
3 years, 11 months ago (2017-01-20 07:28:14 UTC) #39
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-20 08:27:52 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/180001
3 years, 11 months ago (2017-01-20 08:28:05 UTC) #41
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-20 09:06:52 UTC) #42
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/350274)
3 years, 11 months ago (2017-01-20 09:06:53 UTC) #43
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-20 10:06:46 UTC) #44
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/200001
3 years, 11 months ago (2017-01-20 10:06:57 UTC) #45
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-20 10:46:25 UTC) #46
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/306874)
3 years, 11 months ago (2017-01-20 10:46:26 UTC) #47
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-23 05:06:50 UTC) #48
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/240001
3 years, 11 months ago (2017-01-23 05:06:59 UTC) #49
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-23 07:04:07 UTC) #50
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/368573)
3 years, 11 months ago (2017-01-23 07:04:08 UTC) #51
yosin_UTC9
Patchset #10 (id:220001) has been deleted
3 years, 11 months ago (2017-01-23 09:59:07 UTC) #52
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-24 10:25:42 UTC) #53
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/260001
3 years, 11 months ago (2017-01-24 10:26:03 UTC) #54
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-24 10:27:59 UTC) #55
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/26387) ios-simulator on ...
3 years, 11 months ago (2017-01-24 10:28:01 UTC) #56
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-24 10:45:42 UTC) #57
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/280001
3 years, 11 months ago (2017-01-24 10:45:59 UTC) #58
yosin_UTC9
Patchset #11 (id:260001) has been deleted
3 years, 11 months ago (2017-01-24 10:46:10 UTC) #59
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-24 11:34:10 UTC) #60
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/298389)
3 years, 11 months ago (2017-01-24 11:34:10 UTC) #61
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-26 08:30:59 UTC) #62
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/300001
3 years, 11 months ago (2017-01-26 08:31:14 UTC) #63
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-26 09:10:24 UTC) #64
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/353730)
3 years, 11 months ago (2017-01-26 09:10:25 UTC) #65
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-26 10:20:45 UTC) #66
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/320001
3 years, 11 months ago (2017-01-26 10:20:54 UTC) #67
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-26 10:23:00 UTC) #68
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/142755) ios-device-xcode-clang on ...
3 years, 11 months ago (2017-01-26 10:23:01 UTC) #69
yosin_UTC9
Patchset #12 (id:300001) has been deleted
3 years, 11 months ago (2017-01-26 10:36:01 UTC) #70
yosin_UTC9
Patchset #12 (id:320001) has been deleted
3 years, 11 months ago (2017-01-26 10:48:32 UTC) #71
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-26 10:48:44 UTC) #72
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/340001
3 years, 11 months ago (2017-01-26 10:49:04 UTC) #73
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-26 11:50:48 UTC) #74
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220875)
3 years, 11 months ago (2017-01-26 11:50:49 UTC) #75
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-27 06:38:04 UTC) #76
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/360001
3 years, 10 months ago (2017-01-27 06:38:31 UTC) #77
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-27 07:42:25 UTC) #78
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/377389)
3 years, 10 months ago (2017-01-27 07:42:26 UTC) #79
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-27 10:15:18 UTC) #80
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/380001
3 years, 10 months ago (2017-01-27 10:15:51 UTC) #81
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-27 10:42:05 UTC) #82
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/420001
3 years, 10 months ago (2017-01-27 10:42:25 UTC) #83
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-27 11:25:49 UTC) #84
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/379535)
3 years, 10 months ago (2017-01-27 11:25:50 UTC) #85
yosin_UTC9
Patchset #15 (id:400001) has been deleted
3 years, 10 months ago (2017-01-27 13:08:19 UTC) #86
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-27 13:14:01 UTC) #87
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/440001
3 years, 10 months ago (2017-01-27 13:14:16 UTC) #88
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-27 14:12:27 UTC) #89
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/221875)
3 years, 10 months ago (2017-01-27 14:12:28 UTC) #90
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 10 months ago (2017-01-28 02:01:51 UTC) #91
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 10 months ago (2017-01-28 02:02:36 UTC) #92
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-06 05:17:27 UTC) #93
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/460001
3 years, 10 months ago (2017-02-06 05:17:46 UTC) #94
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-06 05:55:21 UTC) #95
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/358775)
3 years, 10 months ago (2017-02-06 05:55:22 UTC) #96
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-06 06:42:38 UTC) #97
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/480001
3 years, 10 months ago (2017-02-06 06:42:55 UTC) #98
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-06 07:55:36 UTC) #99
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/358802)
3 years, 10 months ago (2017-02-06 07:55:38 UTC) #100
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-06 09:20:59 UTC) #101
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/500001
3 years, 10 months ago (2017-02-06 09:21:08 UTC) #102
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-06 10:33:26 UTC) #103
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/358823)
3 years, 10 months ago (2017-02-06 10:33:27 UTC) #104
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-08 05:28:46 UTC) #105
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/520001
3 years, 10 months ago (2017-02-08 05:29:08 UTC) #106
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-08 06:06:41 UTC) #107
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/10960)
3 years, 10 months ago (2017-02-08 06:06:42 UTC) #108
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-08 07:40:09 UTC) #109
yosin_UTC9
Patchset #21 (id:540001) has been deleted
3 years, 10 months ago (2017-02-08 07:40:23 UTC) #110
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/560001
3 years, 10 months ago (2017-02-08 07:40:30 UTC) #111
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-08 08:20:46 UTC) #112
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/228080) linux_chromium_chromeos_rel_ng on ...
3 years, 10 months ago (2017-02-08 08:20:48 UTC) #113
yosin_UTC9
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 10 months ago (2017-02-08 08:51:47 UTC) #114
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-08 08:52:09 UTC) #115
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/580001
3 years, 10 months ago (2017-02-08 08:52:22 UTC) #116
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-08 09:15:12 UTC) #117
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/208051)
3 years, 10 months ago (2017-02-08 09:15:14 UTC) #118
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-08 09:57:17 UTC) #119
yosin_UTC9
Patchset #22 (id:580001) has been deleted
3 years, 10 months ago (2017-02-08 09:57:30 UTC) #120
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637013002/600001
3 years, 10 months ago (2017-02-08 09:57:42 UTC) #121
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-08 11:20:14 UTC) #122
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 10 months ago (2017-02-08 11:20:17 UTC) #123
Greg Levin
Description was changed from ========== Continue from http://crrev.com/1958093002 After this patch, we will do following: ...
3 years, 10 months ago (2017-02-08 14:59:03 UTC) #124
yosin_UTC9
3 years, 10 months ago (2017-02-09 05:14:07 UTC) #125
Description was changed from

==========
Continue from http://crrev.com/1958093002

After this patch, we will do following:
 - Rename FrameSelection::selection() to computeVisibleSelectionDerprecated()
 - Hoist updateStyleAndLayoutIngoringStyleSheet() from
computeVisibleSelectionDerprecated()
 - Interoperabl Selection API; no canonicalization
 - Multiple range selection
 - Move VisiblePosition and VisibleSelection to editing/core/commands

We use |Selection| to hold DOM positions to support shadow DOM.


BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991

[1] https://codereview.chromium.org/1654123002 FrameSelectionTest for caret
paiting

# Failed tests 2017-01-27T22:10:22
editing/execCommand/indent-button-crash.html (Mac only)
interactive_ui_tests LoginTest.GaiaAuthOffline

# Failed tests 2017-01-19T16:37
editing/execCommand/indent-paragraphs.html

Due by call FrameCaret::setCaretRectDirty() in FrameSelection::commitApperance()
FrameSerializerTest.SVGImageDontCrash
All/FrameViewTest.SetPaintInvalidationDuringUpdateAllLifecyclePhases/0
All/FrameViewTest.SetPaintInvalidationDuringUpdateAllLifecyclePhases/1
All/FrameViewTest.SetPaintInvalidationOutOfUpdateAllLifecyclePhases/1
All/FrameViewTest.SetPaintInvalidationOutOfUpdateAllLifecyclePhases/0
FrameSerializerTest.XMLDeclaration
FrameSelectionTest.InvalidatePreviousCaretAfterRemovingLastCharacter
WebMeaningfulLayoutsTest.NoOverflowInIncrementVisuallyNonEmptyPixelCount
 

# Failed tests 2017-01-18T21:32:44
editing/execCommand/indent-paragraphs.html (Mac)
fast/dom/shadow/selection-in-nested-shadow.html
paint/invalidation/invalidate-caret-before-text-node-update.html
shapedetection/detection-HTMLVideoElement.html

BrowserNavigatorTest.ReuseRVHWithWebUI
 -> We should stop caret time when setCaretVisiblity(Hidden)

# Failed tests 2017-01-17T12:36:24
FrameSelectionTest.InvalidatePreviousCaretAfterRemovingLastCharacter
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Continue to http://crrev.com/2680943004
Continue from http://crrev.com/1958093002

After this patch, we will do following:
 - Rename FrameSelection::selection() to computeVisibleSelectionDerprecated()
 - Hoist updateStyleAndLayoutIngoringStyleSheet() from
computeVisibleSelectionDerprecated()
 - Interoperabl Selection API; no canonicalization
 - Multiple range selection
 - Move VisiblePosition and VisibleSelection to editing/core/commands

We use |Selection| to hold DOM positions to support shadow DOM.


BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991

[1] https://codereview.chromium.org/1654123002 FrameSelectionTest for caret
paiting

# Failed tests 2017-01-27T22:10:22
editing/execCommand/indent-button-crash.html (Mac only)
interactive_ui_tests LoginTest.GaiaAuthOffline

# Failed tests 2017-01-19T16:37
editing/execCommand/indent-paragraphs.html

Due by call FrameCaret::setCaretRectDirty() in FrameSelection::commitApperance()
FrameSerializerTest.SVGImageDontCrash
All/FrameViewTest.SetPaintInvalidationDuringUpdateAllLifecyclePhases/0
All/FrameViewTest.SetPaintInvalidationDuringUpdateAllLifecyclePhases/1
All/FrameViewTest.SetPaintInvalidationOutOfUpdateAllLifecyclePhases/1
All/FrameViewTest.SetPaintInvalidationOutOfUpdateAllLifecyclePhases/0
FrameSerializerTest.XMLDeclaration
FrameSelectionTest.InvalidatePreviousCaretAfterRemovingLastCharacter
WebMeaningfulLayoutsTest.NoOverflowInIncrementVisuallyNonEmptyPixelCount
 

# Failed tests 2017-01-18T21:32:44
editing/execCommand/indent-paragraphs.html (Mac)
fast/dom/shadow/selection-in-nested-shadow.html
paint/invalidation/invalidate-caret-before-text-node-update.html
shapedetection/detection-HTMLVideoElement.html

BrowserNavigatorTest.ReuseRVHWithWebUI
 -> We should stop caret time when setCaretVisiblity(Hidden)

# Failed tests 2017-01-17T12:36:24
FrameSelectionTest.InvalidatePreviousCaretAfterRemovingLastCharacter
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

Powered by Google App Engine
This is Rietveld 408576698