Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2651803007: Added isHandleVisible to |SelectionTemplate| (Closed)

Created:
3 years, 10 months ago by amaralp
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added isHandleVisible to |SelectionTemplate| BUG=633281 Review-Url: https://codereview.chromium.org/2651803007 Cr-Commit-Position: refs/heads/master@{#446241} Committed: https://chromium.googlesource.com/chromium/src/+/2b4cb7fad5476bbaf978c4d9ee81d44bf421da92

Patch Set 1 #

Patch Set 2 : forgot to add setIsHandleVisible #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionTemplate.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionTemplate.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionTemplateTest.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
amaralp
This is CL is per your comment on ccrev.com/2647283006.
3 years, 10 months ago (2017-01-26 03:09:06 UTC) #12
yosin_UTC9
lgtm
3 years, 10 months ago (2017-01-26 04:43:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651803007/20001
3 years, 10 months ago (2017-01-26 04:43:58 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 05:48:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b4cb7fad5476bbaf978c4d9ee81...

Powered by Google App Engine
This is Rietveld 408576698