Issue 2660433002: Use https when accessing test-results sever

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2660433002: Use https when accessing test-results sever (Closed)

Created:
3 years, 11 months ago by Sergiy Byelozyorov

Modified:
3 years, 10 months ago

Reviewers:
Dirk Pranke

Target Ref:
refs/heads/master

Project:
typ

Visibility:
Public.

More Reviews

Description

Use https when accessing test-results sever R=dpranke@chromium.org BUG=664583

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	typ/fakes/tests/test_result_server_fake_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	typ/json_results.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	typ/tests/json_results_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

I've landed the change, pushed a new version, and am rolling it into chromium in ...

3 years, 10 months ago (2017-01-29 00:47:51 UTC) #4

Sergiy Byelozyorov

On 2017/01/29 00:47:51, Dirk Pranke wrote: > I've landed the change, pushed a new version, ...

3 years, 10 months ago (2017-01-30 07:58:20 UTC) #5

Dirk Pranke

3 years, 10 months ago (2017-02-10 23:05:47 UTC) #6

Message was sent while issue was closed.

On 2017/01/30 07:58:20, Sergiy Byelozyorov wrote:
> On 2017/01/29 00:47:51, Dirk Pranke wrote:
> > I've landed the change, pushed a new version, and am rolling it into
chromium
> in
> > https://codereview.chromium.org/2658933006 .
> > 
> > Once that lands you can presumably land the android change in the other CL
as
> > well.
> 
> Awesome. Thanks.

Turns out this change actually broke the typ tests. I'm not sure how I missed
that.

At any rate, I'll post a follow-on fix so that the tests work again.

Expand Messages | Collapse Messages