Switch mash_browser_tests to Ozone X11 platform.

Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

BUG=664570
Review-Url: https://codereview.chromium.org/2675443002
Cr-Commit-Position: refs/heads/master@{#448703}
Committed: https://chromium.googlesource.com/chromium/src/+/18eef539260cdf6ca1f5dbfbb0a44cbf836a5824

[kylechar, 2017-02-02 19:51:33]

Patchset #7 (id:110001) has been deleted

[kylechar, 2017-02-06 15:38:30]

Description was changed from

==========
Switch mash_browser_tests to Ozone X11.

The test appears to pass with Ozone X11 without any changes. No reason
to run with Ozone headless now.

BUG=664570
==========

to

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

BUG=664570
==========

[kylechar, 2017-02-06 15:43:56]

Patchset #9 (id:170001) has been deleted

[kylechar, 2017-02-06 16:01:24]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[kylechar, 2017-02-06 16:01:38]

Description was changed from

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

BUG=664570
==========

to

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

BUG=664570
==========

[sky, 2017-02-06 16:14:07]

LGTM

[kylechar, 2017-02-06 16:20:08]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 16:20:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 16:34:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:34:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kylechar, 2017-02-07 18:38:46]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 18:39:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:40:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 19:40:54]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-02-07 19:42:18]

Thanks sky!

[kylechar, 2017-02-07 19:42:23]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-02-07 19:42:23]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2675443002/#ps210001
(title: "Only if use_aura.")

[commit-bot: I haz the power, 2017-02-07 19:42:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:49:02]

CQ is committing da patch.

Bot data: {"patchset_id": 210001, "attempt_start_ts": 1486496543330950,
"parent_rev": "c3ffab1ea15cbd2c70c84cd785fd14e23052e332", "commit_rev":
"18eef539260cdf6ca1f5dbfbb0a44cbf836a5824"}

[commit-bot: I haz the power, 2017-02-07 19:49:59]

Description was changed from

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

BUG=664570
==========

to

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

BUG=664570

Review-Url: https://codereview.chromium.org/2675443002
Cr-Commit-Position: refs/heads/master@{#448703}
Committed:
https://chromium.googlesource.com/chromium/src/+/18eef539260cdf6ca1f5dbfbb0a4...
==========

[commit-bot: I haz the power, 2017-02-07 19:50:00]

Committed patchset #10 (id:210001) as
https://chromium.googlesource.com/chromium/src/+/18eef539260cdf6ca1f5dbfbb0a4...

[jam, 2017-02-07 21:14:46]

A revert of this CL (patchset #10 id:210001) has been created in
https://codereview.chromium.org/2683633003/ by jam@chromium.org.

The reason for reverting is: Looks like the only culprit that caused win bots to
fail compile, i.e.
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FWin%2F51649%2....

[sky, 2017-02-07 21:21:00]

On 2017/02/07 21:14:46, jam wrote:
> A revert of this CL (patchset #10 id:210001) has been created in
> https://codereview.chromium.org/2683633003/ by mailto:jam@chromium.org.
> 
> The reason for reverting is: Looks like the only culprit that caused win bots
to
> fail compile, i.e.
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FWin%2F51649%2....

In looking at this patch again, I do have a question. Does this mean if someone
wants to run locally they have to remember to pass in
--service-overrides=../../chrome/app/mash/mash_service_overrides.json ? That
seems rather error prone.

[kylechar, 2017-02-07 21:25:31]

On 2017/02/07 21:21:00, sky wrote:
> On 2017/02/07 21:14:46, jam wrote:
> > A revert of this CL (patchset #10 id:210001) has been created in
> > https://codereview.chromium.org/2683633003/ by mailto:jam@chromium.org.
> > 
> > The reason for reverting is: Looks like the only culprit that caused win
bots
> to
> > fail compile, i.e.
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FWin%2F51649%2....
> 
> In looking at this patch again, I do have a question. Does this mean if
someone
> wants to run locally they have to remember to pass in
> --service-overrides=../../chrome/app/mash/mash_service_overrides.json ? That
> seems rather error prone.

Yes, to run locally you would have to run something like:

./browser_tests --run-in-mash --use-test-config
--service-overrides=../../chrome/app/mash/mash_service_overrides.json
--gtest_filter=<tests>

It does seem error prone but it also was also true before without this CL.

[kylechar, 2017-02-07 21:26:21]

On 2017/02/07 21:25:31, kylechar wrote:
> On 2017/02/07 21:21:00, sky wrote:
> > On 2017/02/07 21:14:46, jam wrote:
> > > A revert of this CL (patchset #10 id:210001) has been created in
> > > https://codereview.chromium.org/2683633003/ by mailto:jam@chromium.org.
> > > 
> > > The reason for reverting is: Looks like the only culprit that caused win
> bots
> > to
> > > fail compile, i.e.
> > >
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FWin%2F51649%2....
> > 
> > In looking at this patch again, I do have a question. Does this mean if
> someone
> > wants to run locally they have to remember to pass in
> > --service-overrides=../../chrome/app/mash/mash_service_overrides.json ? That
> > seems rather error prone.
> 
> Yes, to run locally you would have to run something like:
> 
> ./browser_tests --run-in-mash --use-test-config
> --service-overrides=../../chrome/app/mash/mash_service_overrides.json
> --gtest_filter=<tests>
> 
> It does seem error prone but it also was also true before without this CL.

*but it was also true without this CL.

[kylechar, 2017-02-07 22:23:35]

On 2017/02/07 21:26:21, kylechar wrote:
> On 2017/02/07 21:25:31, kylechar wrote:
> > On 2017/02/07 21:21:00, sky wrote:
> > > On 2017/02/07 21:14:46, jam wrote:
> > > > A revert of this CL (patchset #10 id:210001) has been created in
> > > > https://codereview.chromium.org/2683633003/ by mailto:jam@chromium.org.
> > > > 
> > > > The reason for reverting is: Looks like the only culprit that caused win
> > bots
> > > to
> > > > fail compile, i.e.
> > > >
> > >
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FWin%2F51649%2....
> > > 
> > > In looking at this patch again, I do have a question. Does this mean if
> > someone
> > > wants to run locally they have to remember to pass in
> > > --service-overrides=../../chrome/app/mash/mash_service_overrides.json ?
That
> > > seems rather error prone.
> > 
> > Yes, to run locally you would have to run something like:
> > 
> > ./browser_tests --run-in-mash --use-test-config
> > --service-overrides=../../chrome/app/mash/mash_service_overrides.json
> > --gtest_filter=<tests>
> > 
> > It does seem error prone but it also was also true before without this CL.
> 
> *but it was also true without this CL.

I think I see the problem. The Windows waterfall builds target "all". I added a
dependency from //chrome/test:mash_browser_tests to something in
//chrome/apps/mash, which causes everything under //chrome/apps/mash to get
built. This involves building things that are Chrome OS only and fail to compile
on Windows. I'll have to look at the dependencies more closely and figure out
how best to fix it.

[sky, 2017-02-07 23:14:43]

On Tue, Feb 7, 2017 at 1:26 PM,  <kylechar@chromium.org> wrote:
> On 2017/02/07 21:25:31, kylechar wrote:
>> On 2017/02/07 21:21:00, sky wrote:
>> > On 2017/02/07 21:14:46, jam wrote:
>> > > A revert of this CL (patchset #10 id:210001) has been created in
>> > > https://codereview.chromium.org/2683633003/ by
>> > > mailto:jam@chromium.org.
>> > >
>> > > The reason for reverting is: Looks like the only culprit that caused
>> > > win
>> bots
>> > to
>> > > fail compile, i.e.
>> > >
>> >
>>
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FWin%2F51649%2....
>> >
>> > In looking at this patch again, I do have a question. Does this mean if
>> someone
>> > wants to run locally they have to remember to pass in
>> > --service-overrides=../../chrome/app/mash/mash_service_overrides.json ?
>> > That
>> > seems rather error prone.
>>
>> Yes, to run locally you would have to run something like:
>>
>> ./browser_tests --run-in-mash --use-test-config
>> --service-overrides=../../chrome/app/mash/mash_service_overrides.json
>> --gtest_filter=<tests>
>>
>> It does seem error prone but it also was also true before without this CL.
>
> *but it was also true without this CL.

Bummer! I hadn't realized that.

  -Scott

>
> https://codereview.chromium.org/2675443002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.