rebaseline-cl: Get latest try jobs using git-cl when no --issue given.

rebaseline-cl: Get latest try jobs using git-cl when no --issue given.

This CL moves filter_latest_builds() into webkitpy.common.net.buildbot,
and adds a method latest_try_jobs to the GitCL class, which behaves like
the latest_try_jobs method currently on the Rietveld class.

The purpose of this change is to make it easier to drop dependency
on Rietveld.

BUG=671684
Review-Url: https://codereview.chromium.org/2692423005
Cr-Commit-Position: refs/heads/master@{#451531}
Committed: https://chromium.googlesource.com/chromium/src/+/e0b4961639a9d8781023e68392847f6fe37f19d9

[qyearsley, 2017-02-16 20:16:49]

qyearsley@chromium.org changed reviewers:
+ wkorman@chromium.org

[drott, 2017-02-17 20:19:34]

Great, thanks for working on this. Can I try this out against gerrit already, or
are there other pieces required?

[qyearsley, 2017-02-17 21:53:18]

On 2017/02/17 at 20:19:34, drott wrote:
> Great, thanks for working on this. Can I try this out against gerrit already,
or are there other pieces required?

I was going to say there are other pieces required, but actually, if you don't
pass --issue or --only-changed-tests, then I think that this is all that's
required; now trying it out at
https://chromium-review.googlesource.com/c/444827/.

(After this CL, the next thing I was thinking of was to use `git diff` to check
for changed files if required, and then drop support for the --issue argument.)

[wkorman, 2017-02-17 23:24:00]

lgtm

https://codereview.chromium.org/2692423005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py (right):

https://codereview.chromium.org/2692423005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py:152:
builder_to_latest_build[build.builder_name] = build
Same as two lines up -- could turn these 4 lines into "if (a or b):
builder_to_latest_build[build.builder_name] = build"?

[qyearsley, 2017-02-17 23:44:36]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 23:45:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-02-17 23:45:34]

https://codereview.chromium.org/2692423005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py (right):

https://codereview.chromium.org/2692423005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py:152:
builder_to_latest_build[build.builder_name] = build
On 2017/02/17 at 23:24:00, wkorman wrote:
> Same as two lines up -- could turn these 4 lines into "if (a or b):
builder_to_latest_build[build.builder_name] = build"?

Yep! Good catch. Now removed this repetition.

[qyearsley, 2017-02-18 00:19:23]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2017-02-18 00:19:24]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-02-18 00:19:24]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2692423005/#ps20001
(title: "Simplify based on feedback; fix docstring; fix all_jobs_finished")

[commit-bot: I haz the power, 2017-02-18 00:20:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:48:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:48:44]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[qyearsley, 2017-02-19 22:34:04]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-02-19 22:34:05]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2692423005/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2017-02-19 22:34:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 23:47:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487543644984650,
"parent_rev": "dbc08d987df8d944144250b50c6cffc044d517c1", "commit_rev":
"e0b4961639a9d8781023e68392847f6fe37f19d9"}

[commit-bot: I haz the power, 2017-02-19 23:47:38]

Description was changed from

==========
rebaseline-cl: Get latest try jobs using git-cl when no --issue given.

This CL moves filter_latest_builds() into webkitpy.common.net.buildbot,
and adds a method latest_try_jobs to the GitCL class, which behaves like
the latest_try_jobs method currently on the Rietveld class.

The purpose of this change is to make it easier to drop dependency
on Rietveld.

BUG=671684
==========

to

==========
rebaseline-cl: Get latest try jobs using git-cl when no --issue given.

This CL moves filter_latest_builds() into webkitpy.common.net.buildbot,
and adds a method latest_try_jobs to the GitCL class, which behaves like
the latest_try_jobs method currently on the Rietveld class.

The purpose of this change is to make it easier to drop dependency
on Rietveld.

BUG=671684

Review-Url: https://codereview.chromium.org/2692423005
Cr-Commit-Position: refs/heads/master@{#451531}
Committed:
https://chromium.googlesource.com/chromium/src/+/e0b4961639a9d8781023e6839284...
==========

[commit-bot: I haz the power, 2017-02-19 23:47:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e0b4961639a9d8781023e6839284...