Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed, and type should be ba…

Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed, and type should be based on a registered Range.

We computed them with normalized selection, a.k.a. VisibleSelection.
This CL improves external/wpt/selection/isCollapsed.html.

Total new PASS: 116
Total new FAIL: 77

Following CLs will resolve FAILs which this CL introduces.

BUG=691887
Review-Url: https://codereview.chromium.org/2694043004
Cr-Commit-Position: refs/heads/master@{#450266}
Committed: https://chromium.googlesource.com/chromium/src/+/94fcc3a62bdcbf2c1342612702b00dae8359ebcc

[tkent, 2017-02-14 02:18:19]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 02:18:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-14 03:54:42]

Description was changed from

==========
Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed,
and type should be based on a registered Range.

We computed them with normalized selection, a.k.a. VisibleSelection.
This CL improves external/wpt/selection/isCollapsed.html.

Total new PASS: 116
Total new FAIL: 77

Following CLs will resolve FAILs which this CL introduces.

BUG=
==========

to

==========
Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed,
and type should be based on a registered Range.

We computed them with normalized selection, a.k.a. VisibleSelection.
This CL improves external/wpt/selection/isCollapsed.html.

Total new PASS: 116
Total new FAIL: 77

Following CLs will resolve FAILs which this CL introduces.

BUG=691887
==========

[commit-bot: I haz the power, 2017-02-14 03:55:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 03:55:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-02-14 03:59:56]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 04:00:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-14 04:00:43]

Patchset #1 (id:1) has been deleted

[tkent, 2017-02-14 04:02:04]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-14 04:02:04]

yosin@, or yoichio@, would you review this please?

[yosin_UTC9, 2017-02-14 04:52:21]

lgtm

https://codereview.chromium.org/2694043004/diff/10001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html
(right):

https://codereview.chromium.org/2694043004/diff/10001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html:53:
shouldBe("getSelection().type", "'Caret'");
Nice, finally, we get correct value of Selection#type.
(^_^)b

https://codereview.chromium.org/2694043004/diff/10001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2694043004/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:446: Range*
DOMSelection::primaryRangeOrNull() const {
Thanks for better name! (^_^)b

https://codereview.chromium.org/2694043004/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:458: Position focus =
focusPosition(visibleSelection());
nit: s/Position/const Position&/

[yosin_UTC9, 2017-02-14 04:52:26]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-14 04:52:34]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-14 04:52:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 05:30:08]

CQ is committing da patch.

Bot data: {"patchset_id": 10001, "attempt_start_ts": 1487047954731810,
"parent_rev": "e7d64d6da7a8f523925a5ed80c3aea74859516e7", "commit_rev":
"94fcc3a62bdcbf2c1342612702b00dae8359ebcc"}

[commit-bot: I haz the power, 2017-02-14 05:30:45]

Description was changed from

==========
Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed,
and type should be based on a registered Range.

We computed them with normalized selection, a.k.a. VisibleSelection.
This CL improves external/wpt/selection/isCollapsed.html.

Total new PASS: 116
Total new FAIL: 77

Following CLs will resolve FAILs which this CL introduces.

BUG=691887
==========

to

==========
Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed,
and type should be based on a registered Range.

We computed them with normalized selection, a.k.a. VisibleSelection.
This CL improves external/wpt/selection/isCollapsed.html.

Total new PASS: 116
Total new FAIL: 77

Following CLs will resolve FAILs which this CL introduces.

BUG=691887

Review-Url: https://codereview.chromium.org/2694043004
Cr-Commit-Position: refs/heads/master@{#450266}
Committed:
https://chromium.googlesource.com/chromium/src/+/94fcc3a62bdcbf2c1342612702b0...
==========

[commit-bot: I haz the power, 2017-02-14 05:30:46]

Committed patchset #1 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/94fcc3a62bdcbf2c1342612702b0...