Remove EditingAppleTabSpan class handling

Remove EditingAppleTabSpan class handling

EditingAppleTabSpan class is non-standard CSS class name
that is produced while creating a span element with tab
in editing, but the usage is low(<=0.0001%).

This CL removes the code that handles EditingAppleTabSpan class
from Blink.

Intent to remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/OlgmGUvnMU4/9HMNXMjGCQAJ

BUG=383677
Review-Url: https://codereview.chromium.org/2718543003
Cr-Commit-Position: refs/heads/master@{#455645}
Committed: https://chromium.googlesource.com/chromium/src/+/013ac5eaf30c02dfa356ba5399da43eb9f368040

[joone, 2017-02-24 02:09:19]

Patchset #1 (id:1) has been deleted

[joone, 2017-02-24 02:09:34]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 02:10:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2017-03-03 22:41:24]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 22:41:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 22:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 22:43:55]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[joone, 2017-03-04 00:35:56]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[joone, 2017-03-04 00:36:02]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-03-04 00:36:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 02:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 02:26:27]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[joone, 2017-03-04 02:35:22]

Description was changed from

==========
Remove EditingAppleTabSpan class handling

EditingAppleTabSpan class is non-standard CSS class name
that was produced while copying text in WebKit, but it is
not produced anymore in Blink and the usage is also low(<=0.0001%).

This CL removes the code that handles EditingAppleTabSpan class
from Blink.

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/OlgmGUvnMU4/9H...

BUG=383677
==========

to

==========
Remove EditingAppleTabSpan class handling

EditingAppleTabSpan class is non-standard CSS class name
that was produced while editing in WebKit, but it is
not produced anymore in Blink and the usage is also low(<=0.0001%).

This CL removes the code that handles EditingAppleTabSpan class
from Blink.

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/OlgmGUvnMU4/9H...

BUG=383677
==========

[joone, 2017-03-04 02:37:46]

Description was changed from

==========
Remove EditingAppleTabSpan class handling

EditingAppleTabSpan class is non-standard CSS class name
that was produced while editing in WebKit, but it is
not produced anymore in Blink and the usage is also low(<=0.0001%).

This CL removes the code that handles EditingAppleTabSpan class
from Blink.

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/OlgmGUvnMU4/9H...

BUG=383677
==========

to

==========
Remove EditingAppleTabSpan class handling

EditingAppleTabSpan class is non-standard CSS class name
that is produced while creating a span element with tab
in editing, but the usage is low(<=0.0001%).

This CL removes the code that handles EditingAppleTabSpan class
from Blink.

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/OlgmGUvnMU4/9H...

BUG=383677
==========

[joone, 2017-03-06 22:52:55]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 22:53:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 00:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 00:12:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[joone, 2017-03-07 04:08:08]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 04:09:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2017-03-07 05:43:04]

joone.hur@intel.com changed reviewers:
+ yosin@chromium.org

[joone, 2017-03-07 05:43:05]

Hi yosin@, could you review this CL?

[yosin_UTC9, 2017-03-07 05:53:17]

https://codereview.chromium.org/2718543003/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/external/wpt/editing/run/inserttext-expected.txt
(right):

https://codereview.chromium.org/2718543003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/external/wpt/editing/run/inserttext-expected.txt:1041:
FAIL [["inserttext","\t"]] "http://a[]" compare innerHTML assert_equals:
Unexpected innerHTML (after normalizing inline style) expected "<a
href=\"http://a\">http://a</a>\t" but got "http://a<span
style=\"white-space:pre\">\t</span>"
It seems we don't need to add |style="white-space:pre"| for "Tab SPAN".
Could you check other browser's behavior?

[commit-bot: I haz the power, 2017-03-07 06:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 06:49:38]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[joone, 2017-03-07 19:13:00]

https://codereview.chromium.org/2718543003/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/external/wpt/editing/run/inserttext-expected.txt
(right):

https://codereview.chromium.org/2718543003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/external/wpt/editing/run/inserttext-expected.txt:1041:
FAIL [["inserttext","\t"]] "http://a[]" compare innerHTML assert_equals:
Unexpected innerHTML (after normalizing inline style) expected "<a
href=\"http://a\">http://a</a>\t" but got "http://a<span
style=\"white-space:pre\">\t</span>"
On 2017/03/07 05:53:17, yosin_UTC9 wrote:
> It seems we don't need to add |style="white-space:pre"| for "Tab SPAN".
> Could you check other browser's behavior?
Yes, I think so. Firefox also doesn't add a <span> tag with tab, but Blink adds 
<span class="Apple-tab-span" style="white-space:pre">	</span> for a tab.
My CL only removes "class=Apple-tab-span".

In order to pass the test fails, we have to add a tab in text node like Firefox.
I will fix it later.

[yosin_UTC9, 2017-03-08 01:29:22]

I'm OK to this change.

Let's land this patch as is to keep changes small.
Then, later patch to remove |<span style="white-space: pre">| to pass WPT test
for improving interoperatbility.

WDYT?

[joone, 2017-03-08 06:00:15]

On 2017/03/08 01:29:22, yosin_UTC9 wrote:
> I'm OK to this change.
> 
> Let's land this patch as is to keep changes small.
> Then, later patch to remove |<span style="white-space: pre">| to pass WPT test
> for improving interoperatbility.
> 
> WDYT?

Sounds great! I will remove it once this CL lands.

[yosin_UTC9, 2017-03-08 07:33:17]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-03-08 07:33:17]

lgtm

[commit-bot: I haz the power, 2017-03-08 07:33:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 07:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 07:43:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[joone, 2017-03-08 10:01:37]

The CQ bit was checked by joone.hur@intel.com

[commit-bot: I haz the power, 2017-03-08 10:02:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 10:10:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 10:10:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[joone, 2017-03-08 15:33:58]

joone.hur@intel.com changed reviewers:
+ bokan@chromium.org

[joone, 2017-03-08 15:33:59]

bokan@ please review this CL.

[bokan, 2017-03-08 23:33:15]

rs lgtm based on Yosin's review.

[joone, 2017-03-08 23:53:33]

The CQ bit was checked by joone.hur@intel.com

[commit-bot: I haz the power, 2017-03-08 23:54:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 02:30:30]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489017213790440,
"parent_rev": "8f4b7a0506f076b26b76dd6aaf624860a6d3fda1", "commit_rev":
"013ac5eaf30c02dfa356ba5399da43eb9f368040"}

[commit-bot: I haz the power, 2017-03-09 02:31:12]

Description was changed from

==========
Remove EditingAppleTabSpan class handling

EditingAppleTabSpan class is non-standard CSS class name
that is produced while creating a span element with tab
in editing, but the usage is low(<=0.0001%).

This CL removes the code that handles EditingAppleTabSpan class
from Blink.

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/OlgmGUvnMU4/9H...

BUG=383677
==========

to

==========
Remove EditingAppleTabSpan class handling

EditingAppleTabSpan class is non-standard CSS class name
that is produced while creating a span element with tab
in editing, but the usage is low(<=0.0001%).

This CL removes the code that handles EditingAppleTabSpan class
from Blink.

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/OlgmGUvnMU4/9H...

BUG=383677

Review-Url: https://codereview.chromium.org/2718543003
Cr-Commit-Position: refs/heads/master@{#455645}
Committed:
https://chromium.googlesource.com/chromium/src/+/013ac5eaf30c02dfa356ba5399da...
==========

[commit-bot: I haz the power, 2017-03-09 02:31:14]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/013ac5eaf30c02dfa356ba5399da...

[joone, 2017-03-11 00:51:43]

https://codereview.chromium.org/2718543003/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/external/wpt/editing/run/inserttext-expected.txt
(right):

https://codereview.chromium.org/2718543003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/external/wpt/editing/run/inserttext-expected.txt:1041:
FAIL [["inserttext","\t"]] "http://a[]" compare innerHTML assert_equals:
Unexpected innerHTML (after normalizing inline style) expected "<a
href=\"http://a\">http://a</a>\t" but got "http://a<span
style=\"white-space:pre\">\t</span>"
On 2017/03/07 05:53:17, yosin_UTC9 wrote:
> It seems we don't need to add |style="white-space:pre"| for "Tab SPAN".
> Could you check other browser's behavior?

yosin@ do we need to create <a> for "http://a" while normalizing inline style?