Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, kinuko+watch, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate BUG=694179 Review-Url: https://codereview.chromium.org/2723973002 Cr-Commit-Position: refs/heads/master@{#456532} Committed: https://chromium.googlesource.com/chromium/src/+/53b1dc5e2d6c84871013249b7e037375bb26ec70

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename toDOMWindow to toLocalDOMWindow #

Patch Set 3 : Rename toFrameIfNotDetached #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -34 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 2 3 4 5 4 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 2 3 4 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 37 (24 generated)
dcheng
3 years, 9 months ago (2017-03-01 07:52:25 UTC) #4
Yuki
https://codereview.chromium.org/2723973002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8Binding.h File third_party/WebKit/Source/bindings/core/v8/V8Binding.h (right): https://codereview.chromium.org/2723973002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8Binding.h#newcode998 third_party/WebKit/Source/bindings/core/v8/V8Binding.h:998: LocalDOMWindow* toDOMWindow(v8::Local<v8::Context>); Maybe, we should rename this to toLocalDOMWindow? ...
3 years, 9 months ago (2017-03-01 08:08:03 UTC) #6
haraken
LGTM
3 years, 9 months ago (2017-03-01 08:31:42 UTC) #9
dcheng
PTAL, updated (and also renamed toFrameIfNotDetached)
3 years, 9 months ago (2017-03-01 09:45:32 UTC) #11
Yuki
LGTM.
3 years, 9 months ago (2017-03-02 07:54:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723973002/60001
3 years, 9 months ago (2017-03-07 06:29:01 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/378187)
3 years, 9 months ago (2017-03-07 07:59:00 UTC) #20
dcheng
On 2017/03/07 07:59:00, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2017-03-07 09:48:30 UTC) #21
dcheng
PTAL. I rebased and fixed the TODOs (compare PS5 and PS6 to see what changed).
3 years, 9 months ago (2017-03-13 06:30:50 UTC) #28
Yuki
LGTM.
3 years, 9 months ago (2017-03-13 07:36:02 UTC) #31
haraken
LGTM
3 years, 9 months ago (2017-03-13 11:56:47 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723973002/100001
3 years, 9 months ago (2017-03-13 23:09:46 UTC) #34
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:17:40 UTC) #37
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/53b1dc5e2d6c84871013249b7e03...

Powered by Google App Engine
This is Rietveld 408576698