Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 274153002: [android_webview] Pass Context to AwContents constructor. (Closed)

Created:
6 years, 7 months ago by mkosiba (inactive)
Modified:
6 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[android_webview] Pass Context to AwContents constructor. BUG=internal b/11505352 TESTS=build, AndroidWebViewTest NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272156

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -431 lines) Patch
D android_webview/build/aosp_manifest_dev.xml View 1 1 chunk +0 lines, -411 lines 0 comments Download
M android_webview/buildbot/aosp_manifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 10 chunks +16 lines, -14 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/OverScrollGlow.java View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 1 chunk +3 lines, -2 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
mkosiba (inactive)
PTAL
6 years, 7 months ago (2014-05-09 16:22:50 UTC) #1
Torne
lgtm
6 years, 7 months ago (2014-05-09 16:29:45 UTC) #2
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 7 months ago (2014-05-20 15:45:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/274153002/20001
6 years, 7 months ago (2014-05-20 15:47:15 UTC) #4
mkosiba (inactive)
The CQ bit was unchecked by mkosiba@chromium.org
6 years, 7 months ago (2014-05-20 17:54:51 UTC) #5
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 7 months ago (2014-05-21 16:34:35 UTC) #6
mkosiba (inactive)
The CQ bit was unchecked by mkosiba@chromium.org
6 years, 7 months ago (2014-05-21 16:36:09 UTC) #7
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 7 months ago (2014-05-22 08:39:54 UTC) #8
mkosiba (inactive)
The CQ bit was unchecked by mkosiba@chromium.org
6 years, 7 months ago (2014-05-22 08:40:04 UTC) #9
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 7 months ago (2014-05-22 10:33:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/274153002/40001
6 years, 7 months ago (2014-05-22 10:34:29 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 11:06:06 UTC) #12
Message was sent while issue was closed.
Change committed as 272156

Powered by Google App Engine
This is Rietveld 408576698