Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2750373003:
Add resized video input test for WebRtcMediaRecorderBrowserTest (Closed)
DescriptionAdd resized video input test for WebRtcMediaRecorderBrowserTest
This CL adds a new test where canvas input resizes during the recording.
BUG=701450
Review-Url: https://codereview.chromium.org/2750373003
Cr-Commit-Position: refs/heads/master@{#457607}
Committed: https://chromium.googlesource.com/chromium/src/+/6d0510b49f3fa532b29378bf9d45b08374ce1885
Patch Set 1 : #
Total comments: 2
Messages
Total messages: 20 (15 generated)
Description was changed from ========== start BUG= ========== to ========== Add resized video input test for MediaRecorder This CL adds a new test where canvas input resizes during the recording. BUG=701450 ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
PTAL.
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add resized video input test for MediaRecorder This CL adds a new test where canvas input resizes during the recording. BUG=701450 ========== to ========== Add resized video input test for WebRtcMediaRecorderBrowserTest This CL adds a new test where canvas input resizes during the recording. BUG=701450 ==========
lgtm with suggestion. Let's see how the bots react to this. https://codereview.chromium.org/2750373003/diff/20001/content/test/data/media... File content/test/data/media/mediarecorder_test.html (right): https://codereview.chromium.org/2750373003/diff/20001/content/test/data/media... content/test/data/media/mediarecorder_test.html:569: drawOnCanvas(canvas); Could we use stream.requestFrame() instead of painting on the canvas every time? (Doing the var ctx = canvas.getContext('2d'); ctx.fillStyle = 'green'; ctx.fillRect(0, 0, canvas.width, canvas.height); only once, after creation of |canvas|.
https://codereview.chromium.org/2750373003/diff/20001/content/test/data/media... File content/test/data/media/mediarecorder_test.html (right): https://codereview.chromium.org/2750373003/diff/20001/content/test/data/media... content/test/data/media/mediarecorder_test.html:569: drawOnCanvas(canvas); On 2017/03/16 23:15:47, mcasas wrote: > Could we use stream.requestFrame() instead of > painting on the canvas every time? (Doing the > var ctx = canvas.getContext('2d'); > ctx.fillStyle = 'green'; > ctx.fillRect(0, 0, canvas.width, canvas.height); > only once, after creation of |canvas|. requestFrame() makes sure that the next drawn item on canvas is captured. It does not force a drawing on canvas. We still need a mechanism to draw and most common way is rAF().
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489707245578500,
"parent_rev": "d1b654904201c70952cb4d30ec6e3617ee0fd05e", "commit_rev":
"6d0510b49f3fa532b29378bf9d45b08374ce1885"}
Message was sent while issue was closed.
Description was changed from ========== Add resized video input test for WebRtcMediaRecorderBrowserTest This CL adds a new test where canvas input resizes during the recording. BUG=701450 ========== to ========== Add resized video input test for WebRtcMediaRecorderBrowserTest This CL adds a new test where canvas input resizes during the recording. BUG=701450 Review-Url: https://codereview.chromium.org/2750373003 Cr-Commit-Position: refs/heads/master@{#457607} Committed: https://chromium.googlesource.com/chromium/src/+/6d0510b49f3fa532b29378bf9d45... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6d0510b49f3fa532b29378bf9d45... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
