Issue 2765033002: Apply scheglov's fixes for analyzer failures to dev

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2765033002: Apply scheglov's fixes for analyzer failures to dev

Created:
3 years, 9 months ago by keertip

Modified:
3 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/dev

Visibility:
Public.

More Reviews

Description

Apply scheglov's fixes for analyzer failures to dev. These are fixes for failures seen with dev 9.0 #f212815ca303b5067d108554045229b2a475ef77 #5dfc281f2f34165d3f0c1e96204c530e35dd200a BUG=

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -101 lines)			Patch
M	pkg/analyzer/lib/src/dart/element/member.dart	View	5 chunks	+3 lines, -76 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/link.dart	View	2 chunks	+34 lines, -24 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/top_level_inference_test.dart	View	2 chunks	+26 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/task/strong/inferred_type_test.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

keertip

Konstantin, could you take a look to make sure the diffs look ok? Thanks!

3 years, 9 months ago (2017-03-21 18:45:15 UTC) #3

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages