Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2790013002: PaymentHandler: Implement set/get methods in PaymentInstruments (blink) (Closed)

Created:
3 years, 8 months ago by zino
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, gogerald+paymentswatch_chromium.org, viettrungluu+watch_chromium.org, blink-reviews, jam, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, rouslan+payments_chromium.org, darin-cc_chromium.org, mahmadi+paymentswatch_chromium.org, darin (slow to review), sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentHandler: Implement set/get methods in PaymentInstruments (blink) The methods are simply writing and reading PaymentInstrument data to storage. Related Spec Link: https://w3c.github.io/webpayments-payment-apps-api/#payment-instruments See the other CLs in this series: [1/3] http://crrev.com/2790013002 (this patch) [2/3] http://crrev.com/2806133002 (content side and unittests) [3/3] http://crrev.com/2811163002 (js test) BUG=661608 Review-Url: https://codereview.chromium.org/2790013002 Cr-Commit-Position: refs/heads/master@{#464925} Committed: https://chromium.googlesource.com/chromium/src/+/fe1c747c077c99272ebbc2eafe7983b9b9e2d927

Patch Set 1 #

Patch Set 2 : Implement #

Patch Set 3 : Implement #

Patch Set 4 : Implement #

Patch Set 5 : Implement #

Patch Set 6 : PaymentHandler: Implement set/get methods in PaymentInstruments (blink) #

Patch Set 7 : ss #

Total comments: 14

Patch Set 8 : addressed comments #

Total comments: 4

Patch Set 9 : blink #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -16 lines) Patch
M components/payments/mojom/payment_app.mojom View 1 2 3 4 5 6 7 8 1 chunk +18 lines, -0 lines 0 comments Download
M content/browser/payments/payment_manager.h View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/payments/payment_manager.cc View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentInstruments.h View 1 2 3 4 5 6 7 8 3 chunks +19 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp View 1 2 3 4 5 6 7 8 3 chunks +140 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentInstruments.idl View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentManager.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentManager.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (16 generated)
Tom Sepez
I didn't see any code that actually does the writing. Where will that happen? Does ...
3 years, 8 months ago (2017-04-11 17:20:59 UTC) #5
zino
On 2017/04/11 17:20:59, Tom Sepez wrote: > I didn't see any code that actually does ...
3 years, 8 months ago (2017-04-11 19:24:29 UTC) #8
Tom Sepez
This one is LGTM, too. We'll discuss on the second CL.
3 years, 8 months ago (2017-04-11 21:53:25 UTC) #9
please use gerrit instead
lgtm % comments https://codereview.chromium.org/2790013002/diff/140001/third_party/WebKit/Source/modules/payments/PaymentInstruments.h File third_party/WebKit/Source/modules/payments/PaymentInstruments.h (right): https://codereview.chromium.org/2790013002/diff/140001/third_party/WebKit/Source/modules/payments/PaymentInstruments.h#newcode30 third_party/WebKit/Source/modules/payments/PaymentInstruments.h:30: PaymentInstruments(const payments::mojom::blink::PaymentManagerPtr&); explicit. https://codereview.chromium.org/2790013002/diff/140001/third_party/WebKit/Source/modules/payments/PaymentManager.cpp File third_party/WebKit/Source/modules/payments/PaymentManager.cpp ...
3 years, 8 months ago (2017-04-12 19:02:37 UTC) #10
haraken
https://codereview.chromium.org/2790013002/diff/140001/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp File third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp (right): https://codereview.chromium.org/2790013002/diff/140001/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp#newcode107 third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp:107: WTF::Vector<WTF::String>(details.enabledMethods()); Why do we need the static cast? https://codereview.chromium.org/2790013002/diff/140001/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp#newcode120 ...
3 years, 8 months ago (2017-04-13 01:32:32 UTC) #12
zino
haraken@ PTAL, I addressed your comments. Thanks :) https://codereview.chromium.org/2790013002/diff/140001/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp File third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp (right): https://codereview.chromium.org/2790013002/diff/140001/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp#newcode107 third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp:107: WTF::Vector<WTF::String>(details.enabledMethods()); ...
3 years, 8 months ago (2017-04-15 03:30:10 UTC) #18
zino
haraken@, gentle ping.
3 years, 8 months ago (2017-04-17 01:28:49 UTC) #19
haraken
LGTM https://codereview.chromium.org/2790013002/diff/180001/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp File third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp (right): https://codereview.chromium.org/2790013002/diff/180001/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp#newcode38 third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp:38: "There is no stored instrument")); Is "There is ...
3 years, 8 months ago (2017-04-17 07:15:56 UTC) #20
zino
Thank you for review. https://codereview.chromium.org/2790013002/diff/180001/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp File third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp (right): https://codereview.chromium.org/2790013002/diff/180001/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp#newcode38 third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp:38: "There is no stored instrument")); ...
3 years, 8 months ago (2017-04-17 14:17:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790013002/200001
3 years, 8 months ago (2017-04-17 14:18:23 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 15:58:33 UTC) #27
Message was sent while issue was closed.
Committed patchset #9 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/fe1c747c077c99272ebbc2eafe79...

Powered by Google App Engine
This is Rietveld 408576698