Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

The compilation failed on the original CL
https://codereview.chromium.org/2777063003/ because of compiler bug described
in https://crbug.com/703565: to downcast unique_ptr<DictionaryValue>, some
compilers require std::move, harming RVO.

Patch set 1 here is the reverted patch from issue 2777063003 at patchset 80001
(http://crrev.com/2777063003#ps80001).

Following patch sets are working around the compiler issue.

Original issue description follows:

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
TBR=bauerb@chromium.org,finnur@chromium.org,benwells@chromium.org,derat@chromium.org,cpu@chromium.org,atwilson@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2811673002
Cr-Commit-Position: refs/heads/master@{#463222}
Committed: https://chromium.googlesource.com/chromium/src/+/9984ea68709ca1f8c9a8da5f2d27c598da83a85e

[vabr (Chromium), 2017-04-10 10:22:29]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 10:22:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-10 10:52:43]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2017-04-10 10:54:05]

vabr@chromium.org changed reviewers:
+ jdoerrie@chromium.org

[vabr (Chromium), 2017-04-10 10:54:07]

Hi Jan,

Please review the diff between patch set 2 and 1.

I reproduced the compilation failure on the
chromeos_x86-generic_chromium_compile_only_ng trybot, feel free to give your
approval conditionally on that trybot turning green for the fixed patch set.

Cheers,
Vaclav

[jdoerrie, 2017-04-10 11:00:58]

LGTM, thanks for the quick fix!

[vabr (Chromium), 2017-04-10 11:24:09]

Description was changed from

==========
Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and
c/b/extensions

The compilation failed on the original CL
https://codereview.chromium.org/2777063003/ because of compiler bug described
in https://crbug.com/703565: to downcast unique_ptr<DictionaryValue>, some
compilers require std::move, harming RVO.

Patch set 1 here is the reverted patch from issue 2777063003 at patchset 80001
(http://crrev.com/2777063003#ps80001).

Following patch sets are working around the compiler issue.

Original issue description follows:

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
==========

to

==========
Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and
c/b/extensions

The compilation failed on the original CL
https://codereview.chromium.org/2777063003/ because of compiler bug described
in https://crbug.com/703565: to downcast unique_ptr<DictionaryValue>, some
compilers require std::move, harming RVO.

Patch set 1 here is the reverted patch from issue 2777063003 at patchset 80001
(http://crrev.com/2777063003#ps80001).

Following patch sets are working around the compiler issue.

Original issue description follows:

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
TBR=bauerb@chromium.org,finnur@chromium.org,benwells@chromium.org,derat@chrom...
==========

[vabr (Chromium), 2017-04-10 11:24:09]

vabr@chromium.org changed reviewers:
+ atwilson@chromium.org, bauerb@chromium.org, benwells@chromium.org,
cpu@chromium.org, derat@chromium.org, dgozman@chromium.org, finnur@chromium.org

[vabr (Chromium), 2017-04-10 11:26:46]

Thanks, Jan. The bot is green, so I'm landing again.

Finnur: The only change (see diff of patch set 2 against 1) is in
chrome/browser/extensions/api/proxy/proxy_api.cc. It is a mechanical change, so
I'm TBR-ing you.

Everybody else: I added you in TBR for owners coverage, but you already approved
this change in the original CL. There are no changes to the code you already
reviewed.

Cheers,
Vaclav

[vabr (Chromium), 2017-04-10 11:26:57]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-04-10 11:27:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 11:33:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491823617182230,
"parent_rev": "6de4c9216f701b9e0e075bff999350853a9c5a74", "commit_rev":
"9984ea68709ca1f8c9a8da5f2d27c598da83a85e"}

[commit-bot: I haz the power, 2017-04-10 11:34:45]

Description was changed from

==========
Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and
c/b/extensions

The compilation failed on the original CL
https://codereview.chromium.org/2777063003/ because of compiler bug described
in https://crbug.com/703565: to downcast unique_ptr<DictionaryValue>, some
compilers require std::move, harming RVO.

Patch set 1 here is the reverted patch from issue 2777063003 at patchset 80001
(http://crrev.com/2777063003#ps80001).

Following patch sets are working around the compiler issue.

Original issue description follows:

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
TBR=bauerb@chromium.org,finnur@chromium.org,benwells@chromium.org,derat@chrom...
==========

to

==========
Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and
c/b/extensions

The compilation failed on the original CL
https://codereview.chromium.org/2777063003/ because of compiler bug described
in https://crbug.com/703565: to downcast unique_ptr<DictionaryValue>, some
compilers require std::move, harming RVO.

Patch set 1 here is the reverted patch from issue 2777063003 at patchset 80001
(http://crrev.com/2777063003#ps80001).

Following patch sets are working around the compiler issue.

Original issue description follows:

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
TBR=bauerb@chromium.org,finnur@chromium.org,benwells@chromium.org,derat@chrom...

Review-Url: https://codereview.chromium.org/2811673002
Cr-Commit-Position: refs/heads/master@{#463222}
Committed:
https://chromium.googlesource.com/chromium/src/+/9984ea68709ca1f8c9a8da5f2d27...
==========

[commit-bot: I haz the power, 2017-04-10 11:34:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9984ea68709ca1f8c9a8da5f2d27...

[Finnur, 2017-04-10 15:48:06]

LGTM