Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2816113002:
Fix to not create jumplist icon files that aren't used by shell (Closed)
DescriptionFix to not create jumplist icon files that aren't used by shell
The current implementation creates more icon files than necessary. In
more details, it first creates icon files for all the retrieved most
visited pages and recently closed pages. The total number of icon files
created is up to 24. However, only at most 10 icons will be used by the
shell. The extra file IO is completely unnecessary.
This CL fixes this issue by only creating the icon files that are used
by shell.
BUG=40407, 179576, 715902
Review-Url: https://codereview.chromium.org/2816113002
Cr-Commit-Position: refs/heads/master@{#465002}
Committed: https://chromium.googlesource.com/chromium/src/+/a27e1c2a48ee40ed2df55effe6d7a15242dd6933
Patch Set 1 #Patch Set 2 : Update UMA histogram function's position to make it more accurate #
Total comments: 2
Messages
Total messages: 34 (27 generated)
Description was changed from ========== [Fixed] Not create jumplist icon files that aren't used by shell BUG=40407, 179576 ========== to ========== [Fixed] Not create jumplist icon files that aren't used by shell Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the most visited pages and recently closed pages. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ==========
Description was changed from ========== [Fixed] Not create jumplist icon files that aren't used by shell Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the most visited pages and recently closed pages. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ========== to ========== Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the most visited pages and recently closed pages. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ==========
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the most visited pages and recently closed pages. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ========== to ========== Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files is typically 24 for Chrome stable versions. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ==========
Description was changed from ========== Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files is typically 24 for Chrome stable versions. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ========== to ========== Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files is typically 24 for Chrome stable versions. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ==========
Description was changed from ========== Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files is typically 24 for Chrome stable versions. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ========== to ========== Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is typically 24 for Chrome stable versions. However, only 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ==========
Description was changed from ========== Not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is typically 24 for Chrome stable versions. However, only 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ========== to ========== Fix to not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is typically 24 for Chrome stable versions. However, only 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
chengx@chromium.org changed reviewers: + gab@chromium.org
PTAL~
Description was changed from ========== Fix to not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is typically 24 for Chrome stable versions. However, only 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ========== to ========== Fix to not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is up to 24. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ==========
chengx@chromium.org changed reviewers: + pmonette@chromium.org
Gentle ping~ Adding another owner pmonette@ in case gab@ is busy. Hopeing this CL can catch the Canary build tomorrow morning.
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by chengx@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492460486502360,
"parent_rev": "e54770e94d8afdd07a2d6bba62c317b023204cd0", "commit_rev":
"a27e1c2a48ee40ed2df55effe6d7a15242dd6933"}
Message was sent while issue was closed.
Description was changed from ========== Fix to not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is up to 24. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 ========== to ========== Fix to not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is up to 24. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 Review-Url: https://codereview.chromium.org/2816113002 Cr-Commit-Position: refs/heads/master@{#465002} Committed: https://chromium.googlesource.com/chromium/src/+/a27e1c2a48ee40ed2df55effe6d7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a27e1c2a48ee40ed2df55effe6d7...
Message was sent while issue was closed.
lgtm https://codereview.chromium.org/2816113002/diff/40001/chrome/browser/win/jump... File chrome/browser/win/jumplist.cc (right): https://codereview.chromium.org/2816113002/diff/40001/chrome/browser/win/jump... chrome/browser/win/jumplist.cc:230: SCOPED_UMA_HISTOGRAM_TIMER("WinJumplist.UpdateJumpListDuration"); This changed the timing of this histogram without renaming it, typically we would have made this "WinJumplist.UpdateJumpListDuration2" in this change. Now, after commit, though I guess it's fine if you'll always filter by version while investigating and remove it later.
Message was sent while issue was closed.
https://codereview.chromium.org/2816113002/diff/40001/chrome/browser/win/jump... File chrome/browser/win/jumplist.cc (right): https://codereview.chromium.org/2816113002/diff/40001/chrome/browser/win/jump... chrome/browser/win/jumplist.cc:230: SCOPED_UMA_HISTOGRAM_TIMER("WinJumplist.UpdateJumpListDuration"); On 2017/04/18 19:21:11, gab wrote: > This changed the timing of this histogram without renaming it, typically we > would have made this "WinJumplist.UpdateJumpListDuration2" in this change. > > Now, after commit, though I guess it's fine if you'll always filter by version > while investigating and remove it later. I am now heavily using version filters (thanks for pointing me to that functionality), so I think this is fine for debugging purpose.
Message was sent while issue was closed.
Description was changed from ========== Fix to not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is up to 24. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576 Review-Url: https://codereview.chromium.org/2816113002 Cr-Commit-Position: refs/heads/master@{#465002} Committed: https://chromium.googlesource.com/chromium/src/+/a27e1c2a48ee40ed2df55effe6d7... ========== to ========== Fix to not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is up to 24. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576, 715901 Review-Url: https://codereview.chromium.org/2816113002 Cr-Commit-Position: refs/heads/master@{#465002} Committed: https://chromium.googlesource.com/chromium/src/+/a27e1c2a48ee40ed2df55effe6d7... ==========
Message was sent while issue was closed.
Description was changed from ========== Fix to not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is up to 24. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576, 715901 Review-Url: https://codereview.chromium.org/2816113002 Cr-Commit-Position: refs/heads/master@{#465002} Committed: https://chromium.googlesource.com/chromium/src/+/a27e1c2a48ee40ed2df55effe6d7... ========== to ========== Fix to not create jumplist icon files that aren't used by shell The current implementation creates more icon files than necessary. In more details, it first creates icon files for all the retrieved most visited pages and recently closed pages. The total number of icon files created is up to 24. However, only at most 10 icons will be used by the shell. The extra file IO is completely unnecessary. This CL fixes this issue by only creating the icon files that are used by shell. BUG=40407, 179576, 715902 Review-Url: https://codereview.chromium.org/2816113002 Cr-Commit-Position: refs/heads/master@{#465002} Committed: https://chromium.googlesource.com/chromium/src/+/a27e1c2a48ee40ed2df55effe6d7... ========== |
