Chrome Cleaner UI: update the modal dialog

Chrome Cleaner UI: update the modal dialog

This is the next iteration of the modal dialog based on UX team's
latest proposal. Strings are still not finalized.

BUG=690020
Review-Url: https://codereview.chromium.org/2847643002
Cr-Commit-Position: refs/heads/master@{#467858}
Committed: https://chromium.googlesource.com/chromium/src/+/d2f9f9ff225693ec2dc17919217abb1d284330f2

[alito, 2017-04-27 02:55:49]

alito@chromium.org changed reviewers:
+ sky@chromium.org

[alito, 2017-04-27 02:55:49]

Sending the next iteration of the Chrome Cleaner modal dialog based on the UX
team's latest proposal. Strings are still being worked on, so they are just
place holders for now.

PTAL.

[sky, 2017-04-27 15:17:32]

https://codereview.chromium.org/2847643002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/srt_prompt_controller.h (right):

https://codereview.chromium.org/2847643002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_prompt_controller.h:22: class
SRTPromptController {
I think I mentioned this last time, but SRT is an acronym that I have no idea
what it means. Can you please rename these to something more readily understood.
MalwareRemoverController or HarmfulSoftwareRemoverController readily convey what
this class is intended for. Same comment for the dialog.

https://codereview.chromium.org/2847643002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_prompt_controller.h:51: void Advanced();
It's not clear 'advanced' is a verb. Please use a better name.

[alito, 2017-04-27 18:21:37]

Patchset #3 (id:40001) has been deleted

[alito, 2017-04-27 18:27:10]

Scott, I renamed the classes and files (SRT is now ChromeCleaner) in a separate
cl that I sent out here: https://codereview.chromium.org/2848683002/

PTAL.

https://codereview.chromium.org/2847643002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/srt_prompt_controller.h (right):

https://codereview.chromium.org/2847643002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_prompt_controller.h:51: void Advanced();
On 2017/04/27 15:17:32, sky wrote:
> It's not clear 'advanced' is a verb. Please use a better name.

Done. Changed to AdvancedButtonClicked().

[sky, 2017-04-27 22:13:49]

LGTM

[alito, 2017-04-27 22:33:17]

alito@chromium.org changed reviewers:
+ mattm@chromium.org

[alito, 2017-04-27 22:33:18]

Adding mattm@ for OWNERS approval for chrome/browsing/safe_browsing/*

[mattm, 2017-04-27 22:54:38]

lgtm stamp

[alito, 2017-04-28 01:51:38]

The CQ bit was checked by alito@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:52:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:56:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493344298414020,
"parent_rev": "77a4bd9d48145f782e8cc1f3f2f6788001f33060", "commit_rev":
"d2f9f9ff225693ec2dc17919217abb1d284330f2"}

[commit-bot: I haz the power, 2017-04-28 02:56:54]

Description was changed from

==========
Chrome Cleaner UI: update the modal dialog

This is the next iteration of the modal dialog based on UX team's
latest proposal. Strings are still not finalized.

BUG=690020
==========

to

==========
Chrome Cleaner UI: update the modal dialog

This is the next iteration of the modal dialog based on UX team's
latest proposal. Strings are still not finalized.

BUG=690020

Review-Url: https://codereview.chromium.org/2847643002
Cr-Commit-Position: refs/heads/master@{#467858}
Committed:
https://chromium.googlesource.com/chromium/src/+/d2f9f9ff225693ec2dc17919217a...
==========

[commit-bot: I haz the power, 2017-04-28 02:56:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d2f9f9ff225693ec2dc17919217a...