Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2858113005: Investigate bug 714841, size regression (Closed)

Created:
3 years, 7 months ago by brucedawson
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Investigate bug 714841, size regression Apply this patch (based on 2762593002) and note the size regression. This patch includes crrev.com/2762593002. It also turns on verbose linking for chrome_child.dll and it converts browser and browser_sources from source_set to static_library. Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=705916 Add --headless flag to Windows: Fix browser_tests not compiling properly on windows Fix headless/BUILD.gn by: - Changing headless_lib to a headless component, following steps in https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md and fixing the build for linux, since it now compiles as a shared_library when component build is true. - Adding neccesary HEADLESS_EXPORT (submitted in https://codereview.chromium.org/2775693003/) - Disabling breakpad in windows (will fix in a separate CL) BUG=714841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -79 lines) Patch
M chrome/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/app/chrome_main.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M headless/BUILD.gn View 11 chunks +148 lines, -37 lines 0 comments Download
M headless/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
M headless/app/headless_example.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M headless/app/headless_shell.h View 1 chunk +1 line, -1 line 0 comments Download
M headless/app/headless_shell.cc View 5 chunks +26 lines, -4 lines 0 comments Download
M headless/app/headless_shell_main.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M headless/app/headless_shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M headless/app/headless_shell_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M headless/lib/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 3 chunks +3 lines, -1 line 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M headless/lib/headless_content_main_delegate.h View 3 chunks +4 lines, -4 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 3 chunks +12 lines, -1 line 0 comments Download
M headless/public/headless_browser.h View 7 chunks +22 lines, -4 lines 0 comments Download
M headless/public/headless_browser.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M headless/public/headless_shell.h View 1 chunk +16 lines, -2 lines 0 comments Download
M headless/public/util/deterministic_http_protocol_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M headless/public/util/generic_url_request_job.h View 4 chunks +4 lines, -3 lines 0 comments Download
M headless/public/util/testing/generic_url_request_mocks.cc View 1 chunk +1 line, -0 lines 0 comments Download
M headless/test/headless_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698