Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2864723002: Enable Feature policy without experimental features or fullscreen (Closed)

Created:
3 years, 7 months ago by iclelland
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, iclelland, eae+blinkwatch, sof, jam, blink-reviews-dom_chromium.org, dglazkov+blink, darin-cc_chromium.org, lunalu1, blink-reviews, kinuko+watch, rwlbuis, Reilly Grant (use Gerrit)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Feature policy without experimental features or fullscreen BUG=623682

Patch Set 1 #

Patch Set 2 : Update layout test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -217 lines) Patch
M content/browser/site_per_process_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-allowed-by-container-policy-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-allowed-by-container-policy-relocate-expected.txt View 1 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-disabled-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-enabledforall-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-enabledforself-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp View 3 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (7 generated)
iclelland
The CQ bit was checked by iclelland@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 19:50:16 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864723002/1
3 years, 7 months ago (2017-05-05 19:51:07 UTC) #2
iclelland
The CQ bit was checked by iclelland@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 19:59:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864723002/20001
3 years, 7 months ago (2017-05-05 19:59:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-05 21:15:16 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/363992)
3 years, 7 months ago (2017-05-05 21:15:18 UTC) #6
Reilly Grant (use Gerrit)
3 years, 7 months ago (2017-05-09 22:46:36 UTC) #7 
Description was changed from

==========
Enable Feature policy without experimental features or fullscreen

BUG=623682
==========

to

==========
Enable Feature policy without experimental features or fullscreen

BUG=623682
==========

Powered by Google App Engine
This is Rietveld 408576698