Remove raw DictionaryValue::Set in //chrome

Remove raw base::DictionaryValue::Set in //chrome

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set in //chrome and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865
Review-Url: https://codereview.chromium.org/2888073002
Cr-Commit-Position: refs/heads/master@{#472473}
Committed: https://chromium.googlesource.com/chromium/src/+/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c

[jdoerrie, 2017-05-17 09:27:04]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 09:27:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 10:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 10:01:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jdoerrie, 2017-05-17 13:32:27]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 13:32:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 14:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 14:30:26]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2017-05-17 14:47:19]

Description was changed from

==========
Remove raw DictionaryValue::Set in //chrome

BUG=
==========

to

==========
Remove raw base::DictionaryValue::Set in //chrome

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set in //chrome and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865
==========

[jdoerrie, 2017-05-17 14:47:19]

jdoerrie@chromium.org changed reviewers:
+ thakis@chromium.org, vabr@chromium.org

[jdoerrie, 2017-05-17 14:48:27]

vabr@chromium.org: Please review the whole CL in detail. 

thakis@chromium.org: Please spot-check and rubber-stamp.

[Nico, 2017-05-17 15:43:10]

Nice, lgtm.

https://codereview.chromium.org/2888073002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_history.h (right):

https://codereview.chromium.org/2888073002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_history.h:71: std::unique_ptr<base::Value>
GetEntriesAsValue() const;
Huh, having a function starting Get... transfer ownership is kind of surprising.
Maybe CopyEntriesAsValue() would be better? (but optional, not for this CL, etc)

[Nico, 2017-05-17 15:43:44]

I looked at everything, so you don't need to wait for vabr, who's currently out.

[jdoerrie, 2017-05-17 16:12:23]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-05-17 16:13:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-05-17 16:23:54]

https://codereview.chromium.org/2888073002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_history.h (right):

https://codereview.chromium.org/2888073002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_history.h:71: std::unique_ptr<base::Value>
GetEntriesAsValue() const;
On 2017/05/17 15:43:10, Nico wrote:
> Huh, having a function starting Get... transfer ownership is kind of
surprising.
> Maybe CopyEntriesAsValue() would be better? (but optional, not for this CL,
etc)

Done: https://codereview.chromium.org/2893653002

[commit-bot: I haz the power, 2017-05-17 16:29:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495037543088030,
"parent_rev": "0d45a3eaaabb9a4ee55fffb80430116bd8271b75", "commit_rev":
"1106bb3b96cb4b6f12764f0a4fb765f7e075aee7"}

[commit-bot: I haz the power, 2017-05-17 16:29:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495037543088030,
"parent_rev": "44fbc4d877cf871eb8d736b4c53a05bb11588931", "commit_rev":
"97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c"}

[commit-bot: I haz the power, 2017-05-17 16:30:07]

Description was changed from

==========
Remove raw base::DictionaryValue::Set in //chrome

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set in //chrome and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865
==========

to

==========
Remove raw base::DictionaryValue::Set in //chrome

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set in //chrome and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865

Review-Url: https://codereview.chromium.org/2888073002
Cr-Commit-Position: refs/heads/master@{#472473}
Committed:
https://chromium.googlesource.com/chromium/src/+/97df444c72d8ec0b4ec6e440dc8e...
==========

[commit-bot: I haz the power, 2017-05-17 16:30:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97df444c72d8ec0b4ec6e440dc8e...