Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2897583002: WebVR unstuffing: delay "rendered" notification (Closed)

Created:
3 years, 7 months ago by klausw
Modified:
3 years, 7 months ago
Reviewers:
mthiesse, bajones
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebVR unstuffing: delay "rendered" notification In order to prevent queue stuffing from overeager frame creation, ensure that we never have more than one frame being rendered while the next frame is being prepared in Javascript. The rendering time should include GVR overhead to avoid overcommitting rendering resources, so this change moves the "rendering done, ok to submit the next frame" notification past GVR submit. BUG=723962 Review-Url: https://codereview.chromium.org/2897583002 Cr-Commit-Position: refs/heads/master@{#474147} Committed: https://chromium.googlesource.com/chromium/src/+/4493e8ab56406db9d3eb2a640662e0e95b383b4a

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 1

Patch Set 4 : Rebase #

Patch Set 5 : Revert pending_time_ change #

Patch Set 6 : Rebase, "depends on" is submitted #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase and squash #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (12 generated)
klausw
3 years, 7 months ago (2017-05-22 22:44:33 UTC) #7
mthiesse
https://codereview.chromium.org/2897583002/diff/40001/chrome/browser/android/vr_shell/vr_shell_gl.cc File chrome/browser/android/vr_shell/vr_shell_gl.cc (right): https://codereview.chromium.org/2897583002/diff/40001/chrome/browser/android/vr_shell/vr_shell_gl.cc#newcode1491 chrome/browser/android/vr_shell/vr_shell_gl.cc:1491: base::TimeDelta time = base::TimeTicks::Now() - vsync_timebase_; I don't think ...
3 years, 7 months ago (2017-05-23 00:14:17 UTC) #9
klausw
On 2017/05/23 00:14:17, mthiesse wrote: > https://codereview.chromium.org/2897583002/diff/40001/chrome/browser/android/vr_shell/vr_shell_gl.cc > File chrome/browser/android/vr_shell/vr_shell_gl.cc (right): > > https://codereview.chromium.org/2897583002/diff/40001/chrome/browser/android/vr_shell/vr_shell_gl.cc#newcode1491 > ...
3 years, 7 months ago (2017-05-23 00:47:05 UTC) #10
klausw
On 2017/05/23 00:47:05, klausw wrote: > On 2017/05/23 00:14:17, mthiesse wrote: > > > https://codereview.chromium.org/2897583002/diff/40001/chrome/browser/android/vr_shell/vr_shell_gl.cc ...
3 years, 7 months ago (2017-05-23 01:04:19 UTC) #11
klausw
On 2017/05/23 01:04:19, klausw wrote: > On 2017/05/23 00:47:05, klausw wrote: > > On 2017/05/23 ...
3 years, 7 months ago (2017-05-23 19:04:51 UTC) #13
klausw
On 2017/05/23 19:04:51, klausw wrote: > On 2017/05/23 01:04:19, klausw wrote: > > On 2017/05/23 ...
3 years, 7 months ago (2017-05-23 19:08:47 UTC) #14
bajones
lgtm
3 years, 7 months ago (2017-05-23 22:38:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897583002/160001
3 years, 7 months ago (2017-05-24 00:35:59 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 03:25:57 UTC) #21
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/4493e8ab56406db9d3eb2a640662...

Powered by Google App Engine
This is Rietveld 408576698