Move "line" granularity related functions to VisibleUnitLine.cpp

Move "line" granularity related functions to VisibleUnitLine.cpp

This patch moves "line" granularity related functions to "VisibleUnitLine.cpp"
for ease of adopting them to Layout NG.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2914793002
Cr-Commit-Position: refs/heads/master@{#476960}
Committed: https://chromium.googlesource.com/chromium/src/+/d4e4efc136c41f9182c0143eec4e15f4bc47ac95

[yosin_UTC9, 2017-05-31 09:15:27]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 09:15:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-05-31 09:35:33]

Description was changed from

==========
2017-05-31T18:13:41

BUG=707656

2017-05-31T18:13:16
==========

to

==========
Move "line" granularity related functions to VisibleUnitLine.cpp

This patch moves "line" granularity related functions to "VisibleUnitLine.cpp"
for ease of adopting them to Layout NG.

BUG=707656
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-05-31 09:36:55]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-05-31 09:36:55]

PTAL

[commit-bot: I haz the power, 2017-05-31 11:40:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 11:40:37]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-31 18:12:22]

https://codereview.chromium.org/2914793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp (right):

https://codereview.chromium.org/2914793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp:2: * Copyright (C)
2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
We should use the Chromium Authors ... copyright notice.

[yosin_UTC9, 2017-06-01 01:09:15]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-06-01 01:09:16]

tkent@, please advice about copyright handling for file splitting.
I'm following your suggestions on five years ago when I split the file.
It is good chance to refresh the knowledge. ;-)

https://codereview.chromium.org/2914793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp (right):

https://codereview.chromium.org/2914793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp:2: * Copyright (C)
2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
On 2017/05/31 at 18:12:21, Xiaocheng wrote:
> We should use the Chromium Authors ... copyright notice.

No, we should use original copyright header.

Dissimilar: I'm not a lawyer, below statements may be valid in the law.

Because, this file is created as:
 1. cp VisibleUnit.cpp VisibleUnitLine.cpp
 2. ... edit something ...

TL;DR: When moving functions to new file, we use copyright header in original.

I know there are lots of counter examples.

1. Create new file with new code
2. Copy some functions from files in different copyright
3. We change copyright of moved functions

tkent@, WDYT?

[tkent, 2017-06-01 01:15:59]

https://codereview.chromium.org/2914793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp (right):

https://codereview.chromium.org/2914793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp:2: * Copyright (C)
2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
On 2017/06/01 at 01:09:16, yosin_UTC9 wrote:
> On 2017/05/31 at 18:12:21, Xiaocheng wrote:
> > We should use the Chromium Authors ... copyright notice.
> 
> No, we should use original copyright header.
> 
> Dissimilar: I'm not a lawyer, below statements may be valid in the law.
> 
> Because, this file is created as:
>  1. cp VisibleUnit.cpp VisibleUnitLine.cpp
>  2. ... edit something ...
> 
> TL;DR: When moving functions to new file, we use copyright header in original.

yeah, I agree about this case.

> I know there are lots of counter examples.
> 
> 1. Create new file with new code
> 2. Copy some functions from files in different copyright
> 3. We change copyright of moved functions
> 
> tkent@, WDYT?

I don't have a clear answer.  Maybe we should have two copyright headers?

[yosin_UTC9, 2017-06-01 02:06:20]

On 2017/06/01 at 01:15:59, tkent wrote:
>
https://codereview.chromium.org/2914793002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp (right):
> 
>
https://codereview.chromium.org/2914793002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp:2: * Copyright (C)
2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
> On 2017/06/01 at 01:09:16, yosin_UTC9 wrote:
> > On 2017/05/31 at 18:12:21, Xiaocheng wrote:
> > > We should use the Chromium Authors ... copyright notice.
> > 
> > No, we should use original copyright header.
> > 
> > Dissimilar: I'm not a lawyer, below statements may be valid in the law.
> > 
> > Because, this file is created as:
> >  1. cp VisibleUnit.cpp VisibleUnitLine.cpp
> >  2. ... edit something ...
> > 
> > TL;DR: When moving functions to new file, we use copyright header in
original.
> 
> yeah, I agree about this case.
> 
> > I know there are lots of counter examples.
> > 
> > 1. Create new file with new code
> > 2. Copy some functions from files in different copyright
> > 3. We change copyright of moved functions
> > 
> > tkent@, WDYT?
> 
> I don't have a clear answer.  Maybe we should have two copyright headers?
Since, we're not lawer, we can't conclude by ourselves.
I'm asking opensource-licensing@google.com to handle this case.
Once, I get response from them, I'll post to blink-dev@

In meantime, I would like to commit this patch as-is, because this new file
is created as:

1. cp VisibleUnits.cpp VisibleUnitsLine.cpp
2. ... edit ...

[yosin_UTC9, 2017-06-05 05:54:54]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 05:55:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-05 05:57:02]

PTAL

I updated copyright header in "VisibleUnitsLine.cpp" to follow opensource
licence professional's
advice[1].

In VisibleUnitsLine.cpp, we have "original copyright" then "chromium copyright".


[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4UmfHnp5Mjk

[tkent, 2017-06-05 06:01:32]

lgtm

[commit-bot: I haz the power, 2017-06-05 08:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 08:12:16]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-06-05 09:10:22]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-05 09:10:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 09:15:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496653822211530,
"parent_rev": "6f940d65aecec58498b3c1a10b5e9943bdc78848", "commit_rev":
"d4e4efc136c41f9182c0143eec4e15f4bc47ac95"}

[commit-bot: I haz the power, 2017-06-05 09:15:18]

Description was changed from

==========
Move "line" granularity related functions to VisibleUnitLine.cpp

This patch moves "line" granularity related functions to "VisibleUnitLine.cpp"
for ease of adopting them to Layout NG.

BUG=707656
TEST=n/a; no behavior changes
==========

to

==========
Move "line" granularity related functions to VisibleUnitLine.cpp

This patch moves "line" granularity related functions to "VisibleUnitLine.cpp"
for ease of adopting them to Layout NG.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2914793002
Cr-Commit-Position: refs/heads/master@{#476960}
Committed:
https://chromium.googlesource.com/chromium/src/+/d4e4efc136c41f9182c0143eec4e...
==========

[commit-bot: I haz the power, 2017-06-05 09:15:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d4e4efc136c41f9182c0143eec4e...