Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2955283002: Revert of Relanding [Android] Adding Smart GO/NEXT feature in Chrome

Created:
3 years, 5 months ago by Takayoshi Kochi (Google)
Modified:
3 years, 5 months ago
CC:
agrieve+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Relanding [Android] Adding Smart GO/NEXT feature in Chrome (patchset #4 id:80001 of https://codereview.chromium.org/2948593002/ ) Reason for revert: This caused perf regression on browse_social_facebook_infinite_scroll test on most platforms. See crbug.com/737388 for details. Original issue's description: > Relanding [Android] Adding Smart GO/NEXT feature in Chrome > > Smart Go/Next brings better user experience to the user during form submitting applications. > For navigating between form elements, user can use NEXT/PREVIOUS button from IME > without touching on individual fields. This will avoid unnecessary form submissions before > filling or visiting all fields in the form. > > Additionally it will save user time and avoid redundant network requests before actually > filling/attending entire fields in the form > > Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing > > Initial patch is reviewed @ https://codereview.chromium.org/2839993002/ > > BUG=410785, 648986, 733222 > > Review-Url: https://codereview.chromium.org/2948593002 > Cr-Commit-Position: refs/heads/master@{#481868} > Committed: https://chromium.googlesource.com/chromium/src/+/4eb6812cc312e4ea919518a4e3087944e31b3b72 TBR=yosin@chromium.org,aelias@chromium.org,changwan@chromium.org,dcheng@chromium.org,kochi@chromium.org,tedchoc@chromium.org,tkent@chromium.org,yfriedman@chromium.org,nasko@chromium.org,ajith.v@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=410785, 648986, 733222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -812 lines) Patch
M content/browser/android/ime_adapter_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/android/ime_adapter_android.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 3 chunks +8 lines, -24 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java View 3 chunks +14 lines, -15 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java View 3 chunks +3 lines, -7 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +0 lines, -64 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java View 5 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M content/test/data/android/input/input_forms.html View 2 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebViewTest.cpp View 2 chunks +0 lines, -483 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 3 chunks +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusControllerTest.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_disabled_and_readonly_elements.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_key_event_listeners.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_tabindex_elements.html View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebFocusType.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebTextInputType.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Takayoshi Kochi (Google)
Created Revert of Relanding [Android] Adding Smart GO/NEXT feature in Chrome
3 years, 5 months ago (2017-06-28 05:43:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955283002/1
3 years, 5 months ago (2017-06-28 05:44:05 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-06-28 05:44:07 UTC) #5
tkent
lgtm
3 years, 5 months ago (2017-06-28 05:44:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955283002/1
3 years, 5 months ago (2017-06-28 05:45:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955283002/1
3 years, 5 months ago (2017-06-28 05:46:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/241214)
3 years, 5 months ago (2017-06-28 05:48:35 UTC) #12
Takayoshi Kochi (Google)
3 years, 5 months ago (2017-06-28 06:21:01 UTC) #13
The conflict is in WebLocalFrame.h (one line diff in
include headers).

For some unknown reason I cannot update this CL, I uploaded
the fixed CL at
https://chromium-review.googlesource.com/c/551697/

Powered by Google App Engine
This is Rietveld 408576698