Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 3006533002: Disable build hooks for WebRTC on Android. (Closed)

Created:
3 years, 4 months ago by sakal
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc, charujain
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable build hooks for WebRTC on Android. BUG=webrtc:8148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M webrtc/examples/BUILD.gn View 4 chunks +12 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/rtc_base/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/sdk/android/BUILD.gn View 3 chunks +9 lines, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sakal
PTAL https://chromium-review.googlesource.com/c/chromium/src/+/632683 Needs to land before this can land
3 years, 4 months ago (2017-08-24 15:12:57 UTC) #4
kjellander_webrtc
On 2017/08/24 15:12:57, sakal wrote: > PTAL > > https://chromium-review.googlesource.com/c/chromium/src/+/632683 > > Needs to land ...
3 years, 4 months ago (2017-08-24 19:22:29 UTC) #5
magjed_webrtc
lgtm
3 years, 3 months ago (2017-08-25 13:16:00 UTC) #6
kjellander_webrtc
3 years, 3 months ago (2017-08-25 15:39:44 UTC) #7
On 2017/08/25 13:16:00, magjed_webrtc wrote:
> lgtm

This was done as part of https://codereview.webrtc.org/3003393002/
Closing this.

Powered by Google App Engine
This is Rietveld 408576698