Issue 302543006: Adds ability to prevent browser connection updates in layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302543006: Adds ability to prevent browser connection updates in layout tests. (Closed)

Created:
6 years, 7 months ago by jkarlin

Modified:
6 years, 6 months ago

Reviewers:
adamk

CC:
blink-reviews, jamesr, arv+blink, abarth-chromium, dglazkov+blink, Inactive, watchdog-blink-watchlist_google.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Adds ability to prevent browser connection updates in layout tests. This is to make the layout tests deterministic and prevent flakes. BUG=377736 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174911

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -1 line)			Patch
M	Source/core/page/NetworkStateNotifier.h	View	1 2	4 chunks	+12 lines, -0 lines	0 comments	Download
M	Source/core/page/NetworkStateNotifier.cpp	View	1 2	2 chunks	+23 lines, -0 lines	0 comments	Download
M	Source/core/testing/Internals.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download
M	Source/core/testing/Internals.idl	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

jkarlin

Hi Adam, this should fix the flaky test issue we discussed.

6 years, 7 months ago (2014-05-27 16:51:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/302543006/50001

6 years, 7 months ago (2014-05-27 20:50:48 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-05-27 22:47:57 UTC) #5

Message was sent while issue was closed.

Change committed as 174911