Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 370733002: [ServiceWorker] Add setURL() and url() to WebServiceWorkerResponse. (Closed)

Created:
6 years, 5 months ago by horo
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add setURL() and url() to WebServiceWorkerResponse. The renderer must know the original url of the result of the fetch event for CORS. BUG=373120 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M Source/platform/exported/WebServiceWorkerResponse.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M public/platform/WebServiceWorkerResponse.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
horo
Could you please review?
6 years, 5 months ago (2014-07-04 08:09:25 UTC) #1
falken
lgtm
6 years, 5 months ago (2014-07-04 09:31:44 UTC) #2
horo
The CQ bit was checked by horo@chromium.org
6 years, 5 months ago (2014-07-04 09:52:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/370733002/1
6 years, 5 months ago (2014-07-04 09:52:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 5 months ago (2014-07-04 10:57:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-04 11:00:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/9340)
6 years, 5 months ago (2014-07-04 11:00:21 UTC) #7
horo
jochen@ Could you please review?
6 years, 5 months ago (2014-07-05 03:45:00 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-07 06:48:04 UTC) #9
horo
The CQ bit was checked by horo@chromium.org
6 years, 5 months ago (2014-07-07 06:54:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/370733002/1
6 years, 5 months ago (2014-07-07 06:55:15 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-07 07:59:31 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 13:32:01 UTC) #13
Message was sent while issue was closed.
Change committed as 177575

Powered by Google App Engine
This is Rietveld 408576698