commit | b6d58e56044f5667d8cd83cea239894dff10670e | [log] [tgz] |
---|---|---|
author | Mike Wasserman <msw@chromium.org> | Mon May 07 16:05:00 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon May 07 16:05:00 2018 |
tree | 1811cbcd4b7a4827e65910e913c25675b2de77fd | |
parent | c83f8839de1fa92cb0aecaabb25ad481419021cc [diff] |
Reland mash: Move SpokenFeedbackEventRewriter to ash; add mojo delegate The original crrev.com/c/1038819 broke volume keys: crbug.com/839683 PS2 fixes that by reposting events to other rewriters and adds a test. ORIGINAL CHANGE DESCRIPTION FOLLOWS: Move the rewriter files to ash, keep the delegate impl in chrome. Add a mojo interface for the delegate to receive and return events. Ash's controller creates the rewriter, Chrome sets the delegate. Move, expand, and refine the existing unit tests. Add TODOs to refine the rewriter/delegate/ChromeVox pattern. (the rewriter shouldn't pass events that will need to be reposted) This should allow Mash to support this rewriter in the future. (for now, Ash doesn't get Window Service events sent to Chrome) TBR=jamescook@chromium.org Bug: 647781 Test: No regressions with ChromeVox spoken feedback on Chrome OS. Change-Id: Id2e778fa3a82aee7f568244a5c2596ab86919a1d Reviewed-on: https://chromium-review.googlesource.com/1044780 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556458}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .