Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Issue 611283002: Android Video Capture: Added static methods for device & capabilities enumeration using Camera2 API (Closed)

Created:
6 years, 2 months ago by mcasas
Modified:
6 years, 1 month ago
Reviewers:
qinmin, magjed_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android Video Capture: Added static methods for device & capabilities enumeration using Camera2 API Also, renamed the new class VideoCaptureAndroid2->VideoCaptureCamera2. (respecting [1]) [1] https://code.google.com/p/chromium/issues/detail?id=418052#c2 BUG=418052 Committed: https://crrev.com/727ab043f6a9c135430fcb5231de215cbeb43eef Cr-Commit-Position: refs/heads/master@{#305347}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : qinmin@ comments #

Patch Set 3 : Renamed the new class VideoCaptureAndroid2 -> VideoCaptureCamera2. #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -12 lines) Patch
A media/base/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 1 2 1 chunk +104 lines, -0 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java View 1 2 3 3 chunks +24 lines, -8 lines 0 comments Download
M media/video/capture/android/video_capture_device_factory_android.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
mcasas
qinmin@: *.java PTAL magjed@: media/video/capture/android/video_capture_device_factory_android.cc https://codereview.chromium.org/611283002/diff/100001/media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java File media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java (right): https://codereview.chromium.org/611283002/diff/100001/media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java#newcode69 media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java:69: == appContext.getPackageManager().checkPermission( presubmit.py indicate ...
6 years, 2 months ago (2014-10-23 08:19:11 UTC) #7
magjed_chromium
video_capture_device_factory_android.cc lgtm
6 years, 2 months ago (2014-10-23 11:49:51 UTC) #10
mcasas
friendly ping
6 years, 2 months ago (2014-10-24 16:14:37 UTC) #12
qinmin
lgtm https://codereview.chromium.org/611283002/diff/120001/media/base/android/java/src/org/chromium/media/VideoCaptureAndroid2.java File media/base/android/java/src/org/chromium/media/VideoCaptureAndroid2.java (right): https://codereview.chromium.org/611283002/diff/120001/media/base/android/java/src/org/chromium/media/VideoCaptureAndroid2.java#newcode34 media/base/android/java/src/org/chromium/media/VideoCaptureAndroid2.java:34: CameraCharacteristics cameraCharacteristics; can we just do the following: ...
6 years, 2 months ago (2014-10-24 22:53:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611283002/160001
6 years, 1 month ago (2014-10-25 17:06:57 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/27689)
6 years, 1 month ago (2014-10-25 17:35:06 UTC) #17
mcasas
https://codereview.chromium.org/611283002/diff/120001/media/base/android/java/src/org/chromium/media/VideoCaptureAndroid2.java File media/base/android/java/src/org/chromium/media/VideoCaptureAndroid2.java (right): https://codereview.chromium.org/611283002/diff/120001/media/base/android/java/src/org/chromium/media/VideoCaptureAndroid2.java#newcode34 media/base/android/java/src/org/chromium/media/VideoCaptureAndroid2.java:34: CameraCharacteristics cameraCharacteristics; On 2014/10/24 22:53:22, qinmin wrote: > can ...
6 years, 1 month ago (2014-10-25 17:46:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611283002/200001
6 years, 1 month ago (2014-11-22 01:54:08 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:200001)
6 years, 1 month ago (2014-11-22 02:46:44 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 02:48:24 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/727ab043f6a9c135430fcb5231de215cbeb43eef
Cr-Commit-Position: refs/heads/master@{#305347}

Powered by Google App Engine
This is Rietveld 408576698