commit | 609997fe600b963b4830c2a713be6839f1856209 | [log] [tgz] |
---|---|---|
author | Sadrul Habib Chowdhury <sadrul@chromium.org> | Sat Dec 15 02:13:18 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Dec 15 02:13:18 2018 |
tree | 215c637358ad13978357d2584759a2e4020cf8fa | |
parent | bed17aa5d736c955436376b8342fd1d451119bbb [diff] |
viz: Always request presentation timestamp from clients. Turn on CompositorFrameMetadata.request_presentation_feedback by default. This would start sending presentation-feedback for every frame submitted by a client. However, the presentation-feedback is now included with the begin-frame messages (crrev.com/608235}, so there is no longer an extra IPC per frame. There is one extra ipc that gets sent: when the client submits the last frame, and does not want any more begin-frames, it still receives a begin-frame carrying the presentation-timestamp for the last submitted frame. But the cost of this is small. This now requires that submitted CompositorFrame has a valid token. A viz::FrameTokenGenerator is introduced to facilitate creating the tokens from the clients. A DCHECK() is also added in the serializer to catch clients sending a CompositorFrame without a valid token. After this stays in tree for a few days, a follow up CL will remove the CompositorFrameMetadata.requested_presentation_feedback flag, and the associated code. TBR=fserb@ for third_party/blink changes. TBR=Bo for android_webview/ changes. TBR=oshima@ for ash/ and components/exo changes. BUG=883592 Change-Id: I70b9b290cab5a31d6cc7597bd737402f9459c10f Reviewed-on: https://chromium-review.googlesource.com/c/1375641 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#616913}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .