Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 640143003: Fix DOM code for VKEY_LCONTROL and VKEY_RCONTROL (Closed)

Created:
6 years, 1 month ago by kelvinp
Modified:
6 years, 1 month ago
Reviewers:
Shu Chen, yukawa, garykac
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix DOM code for VKEY_LCONTROL and VKEY_RCONTROL According to the DOM 3 Spec, http://www.w3.org/TR/DOM-Level-3-Events-code/ the code value for VKEY_LCONTROL should be ControlLeft instead CtrlLeft. (The same is also true for VKEY_RCONTROL) BUG=426660 Committed: https://crrev.com/75270fd7630aceddfcf084039214e0d81c500029 Cr-Commit-Position: refs/heads/master@{#301044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/base/ime/chromeos/ime_keymap.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
kelvinp
@shuchen, I come across this bug in one of my local changes. PTAL
6 years, 1 month ago (2014-10-24 00:01:49 UTC) #3
Shu Chen
lgtm
6 years, 1 month ago (2014-10-24 00:59:26 UTC) #4
kelvinp
yukawa@, can I have an LGTM from you?
6 years, 1 month ago (2014-10-24 01:22:54 UTC) #6
yukawa
lgtm
6 years, 1 month ago (2014-10-24 01:32:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640143003/1
6 years, 1 month ago (2014-10-24 01:51:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/5874) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/10880)
6 years, 1 month ago (2014-10-24 02:09:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640143003/1
6 years, 1 month ago (2014-10-24 02:11:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-24 03:55:14 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 03:55:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75270fd7630aceddfcf084039214e0d81c500029
Cr-Commit-Position: refs/heads/master@{#301044}

Powered by Google App Engine
This is Rietveld 408576698