Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Issue 679223002: Plumb composition character bounds from C++ to Java (Closed)

Created:
6 years, 1 month ago by yukawa
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, penghuang+watch_chromium.org, sadrul, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Plumb composition character bounds from C++ to Java This is a follow up CL of crrev.com/671503005. This CL makes a plumbing from the C++ layer to Java layer so that composition character bounds can be passed to new Android 5.0 IME APIs in subsequent CLs. As discussed in the previous CL, that callback is called in Android 5.0 and later. Hence no performance impact is intended in KitKat and prior. All-in-one CL is available here: http://crrev.com/643193003 BUG=424866 TEST=Manually done on Nexus 7 Build/LPX13D Committed: https://crrev.com/6d6a279a1cf7d9e8b5072740a494c4031eaa133d Cr-Commit-Position: refs/heads/master@{#301808}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comment. Add TODO. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M content/browser/renderer_host/ime_adapter_android.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 1 2 chunks +31 lines, -0 lines 2 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
yukawa
Hi Aurimas, Sadrul. Can you take a look at this CL? aurimas@: everything sadrul@: ontent/browser/renderer_host/*
6 years, 1 month ago (2014-10-27 18:50:51 UTC) #2
yukawa
Sorry Sadrul, please disregard my review request. I mistakenly picked you up from the OWNER ...
6 years, 1 month ago (2014-10-27 19:01:33 UTC) #4
aelias_OOO_until_Jul13
renderer_host LGTM
6 years, 1 month ago (2014-10-27 19:07:52 UTC) #5
aurimas (slooooooooow)
https://codereview.chromium.org/679223002/diff/1/content/browser/renderer_host/ime_adapter_android.cc File content/browser/renderer_host/ime_adapter_android.cc (right): https://codereview.chromium.org/679223002/diff/1/content/browser/renderer_host/ime_adapter_android.cc#newcode281 content/browser/renderer_host/ime_adapter_android.cc:281: if (coordinates_dest_array.is_null()) Why would this be null? Is this ...
6 years, 1 month ago (2014-10-28 05:49:08 UTC) #6
yukawa
Thank you for your review. PTAL, Aurimas? https://codereview.chromium.org/679223002/diff/1/content/browser/renderer_host/ime_adapter_android.cc File content/browser/renderer_host/ime_adapter_android.cc (right): https://codereview.chromium.org/679223002/diff/1/content/browser/renderer_host/ime_adapter_android.cc#newcode281 content/browser/renderer_host/ime_adapter_android.cc:281: if (coordinates_dest_array.is_null()) ...
6 years, 1 month ago (2014-10-28 06:15:16 UTC) #7
aurimas (slooooooooow)
lgtm https://codereview.chromium.org/679223002/diff/20001/content/browser/renderer_host/ime_adapter_android.cc File content/browser/renderer_host/ime_adapter_android.cc (right): https://codereview.chromium.org/679223002/diff/20001/content/browser/renderer_host/ime_adapter_android.cc#newcode290 content/browser/renderer_host/ime_adapter_android.cc:290: coordinates_array[coordinates_array_index + 2] = rect.right(); Do we have ...
6 years, 1 month ago (2014-10-28 20:45:09 UTC) #8
yukawa
https://codereview.chromium.org/679223002/diff/20001/content/browser/renderer_host/ime_adapter_android.cc File content/browser/renderer_host/ime_adapter_android.cc (right): https://codereview.chromium.org/679223002/diff/20001/content/browser/renderer_host/ime_adapter_android.cc#newcode290 content/browser/renderer_host/ime_adapter_android.cc:290: coordinates_array[coordinates_array_index + 2] = rect.right(); On 2014/10/28 20:45:09, aurimas ...
6 years, 1 month ago (2014-10-29 00:50:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679223002/20001
6 years, 1 month ago (2014-10-29 08:27:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-29 09:17:26 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 09:18:14 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6d6a279a1cf7d9e8b5072740a494c4031eaa133d
Cr-Commit-Position: refs/heads/master@{#301808}

Powered by Google App Engine
This is Rietveld 408576698