Issue 680873002: Protect against a seg fault in CPDF_StructElementImpl constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 680873002: Protect against a seg fault in CPDF_StructElementImpl constructor. (Closed)

Created:
6 years, 1 month ago by olsen

Modified:
6 years, 1 month ago

Reviewers:
Tom Sepez, jam

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Visibility:
Public.

More Reviews

Description

Protect against a seg fault in CPDF_StructElementImpl constructor. pTree->m_pRoleMap can be NULL if there is no dict called "RoleMap". This shouldn't cause a segfault - easily fixed with a NULL check. R=jam@google.com

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Post-review 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	core/src/fpdfdoc/doc_tagged.cpp	View	1 2	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Tom Sepez

lgtm https://codereview.chromium.org/680873002/diff/20001/core/src/fpdfdoc/doc_tagged.cpp File core/src/fpdfdoc/doc_tagged.cpp (right): https://codereview.chromium.org/680873002/diff/20001/core/src/fpdfdoc/doc_tagged.cpp#newcode220 core/src/fpdfdoc/doc_tagged.cpp:220: if (pTree->m_pRoleMap != NULL) { nit: != NULL ...

6 years, 1 month ago (2014-11-05 17:57:03 UTC) #3

olsen

6 years, 1 month ago (2014-11-10 00:24:44 UTC) #4

https://codereview.chromium.org/680873002/diff/20001/core/src/fpdfdoc/doc_tag...
File core/src/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/680873002/diff/20001/core/src/fpdfdoc/doc_tag...
core/src/fpdfdoc/doc_tagged.cpp:220: if (pTree->m_pRoleMap != NULL) {
On 2014/11/05 17:57:03, Tom Sepez wrote:
> nit: != NULL is redundant. Just 
>    if (pTree->m_pRoleMap) {

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages