Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 700723004: Do not use vector<scoped_ptr<>>. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not use vector<scoped_ptr<>>. It requires library support so that vector knows about move-only types. This is a C++11 library feature, and these aren't allowed yet as they don't work on all platforms yet. BUG=none Committed: https://crrev.com/6601f743be864cd37bf55c7c8643f21c2eeb7ffe Cr-Commit-Position: refs/heads/master@{#302964}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/midi/midi_manager_win.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M win8/metro_driver/print_document_source.h View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/print_document_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
dmazzoni: chrome/ yukawa: media/ robertshield: win8/
6 years, 1 month ago (2014-11-05 23:16:53 UTC) #2
yukawa
On 2014/11/05 23:16:53, Nico wrote: > dmazzoni: chrome/ > yukawa: media/ > robertshield: win8/ media/: ...
6 years, 1 month ago (2014-11-06 00:05:05 UTC) #3
dmazzoni
lgtm
6 years, 1 month ago (2014-11-06 00:57:20 UTC) #4
robertshield
win8 lgtm
6 years, 1 month ago (2014-11-06 01:01:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700723004/40001
6 years, 1 month ago (2014-11-06 02:31:04 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-06 05:09:24 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 05:10:10 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6601f743be864cd37bf55c7c8643f21c2eeb7ffe
Cr-Commit-Position: refs/heads/master@{#302964}

Powered by Google App Engine
This is Rietveld 408576698