Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 737003003: Set camera parameters continuous focus mode on (Closed)

Created:
6 years, 1 month ago by mcasas
Modified:
6 years, 1 month ago
Reviewers:
qinmin
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android Video Capture: Set continuous focus mode on in cam parameters. This is, apparently, needed for macro modes, although autofocus seems to work ok in general. BUG=343894 TEST=Please refer to the bug, basically a gUM() + close QR codes focus test. Committed: https://crrev.com/667e79783dd2bbd413b165abfd7fae2bfa3210d5 Cr-Commit-Position: refs/heads/master@{#304909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/base/android/java/src/org/chromium/media/VideoCaptureCamera.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mcasas
qinmin@ FYI/RFC :)
6 years, 1 month ago (2014-11-19 19:50:57 UTC) #2
qinmin
lgtm
6 years, 1 month ago (2014-11-19 21:27:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737003003/1
6 years, 1 month ago (2014-11-19 22:01:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 22:42:40 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/667e79783dd2bbd413b165abfd7fae2bfa3210d5 Cr-Commit-Position: refs/heads/master@{#304909}
6 years, 1 month ago (2014-11-19 22:45:16 UTC) #7
tommi (sloooow) - chröme
6 years, 1 month ago (2014-11-20 14:15:15 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/740363002/ by tommi@chromium.org.

The reason for reverting is: Looks like this is causing
MANUAL_CanAcquireVgaOnRealWebcam to fail..

Powered by Google App Engine
This is Rietveld 408576698