Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 755853004: Replace #updateCursor with #updateCursorAnchorInfo (Closed)

Created:
6 years ago by yukawa
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, aurimas (slooooooooow), bcwhite
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace #updateCursor with #updateCursorAnchorInfo This is a groundwork to enable InputMethodManager#updateCursorAnchorInfo support for Android 5.0. Note that this CL only updates InputMethodManagerWrapper and no one is using the new API yet. Hence this CL is supposed to have no impact on the production. In Android 5.0, InputMethodManager#updateCursor and InputMethodManager#isWatchingCursor are deprecated in favor of a new API called InputMethodManager#updateCursorAnchorInfo. This CL updates InputMethodManagerWrapper accordingly. BUG=424866 TEST=unittest Committed: https://crrev.com/7ab95c00ea301a6bb5b250620dd8b1e9362df1f6 Cr-Commit-Position: refs/heads/master@{#306996}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment from Aurimas. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java View 1 2 chunks +10 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
yukawa
Hi Ben. Can you take a look at this CL? android_aosp bot has been updated ...
6 years ago (2014-12-01 19:29:49 UTC) #2
aurimas (slooooooooow)
lgtm https://codereview.chromium.org/755853004/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java File content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java (right): https://codereview.chromium.org/755853004/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java#newcode74 content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java:74: getInputMethodManager().updateCursorAnchorInfo(view, cursorAnchorInfo); Add an API check to make ...
6 years ago (2014-12-04 05:00:22 UTC) #4
yukawa
https://codereview.chromium.org/755853004/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java File content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java (right): https://codereview.chromium.org/755853004/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java#newcode74 content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java:74: getInputMethodManager().updateCursorAnchorInfo(view, cursorAnchorInfo); On 2014/12/04 05:00:22, aurimas wrote: > Add ...
6 years ago (2014-12-04 05:21:00 UTC) #5
yukawa
Hi Jared, can you take a look at this as an OWNER of input? Thanks
6 years ago (2014-12-05 05:44:48 UTC) #7
jdduke (slow)
On 2014/12/05 05:44:48, yukawa wrote: > Hi Jared, can you take a look at this ...
6 years ago (2014-12-05 06:11:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755853004/20001
6 years ago (2014-12-05 07:01:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-05 07:53:52 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-05 07:54:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ab95c00ea301a6bb5b250620dd8b1e9362df1f6
Cr-Commit-Position: refs/heads/master@{#306996}

Powered by Google App Engine
This is Rietveld 408576698