Descriptioncc: Fixing scheduler state machine tests around BeginMainFrameAborted.
This CL does the following;
1) TestGoesInvisibleBeforeFinishCommit -> TestAbortBeginMainFrameBecauseInvisible
2) AbortBeginMainFrameAndCancelCommit -> TestAbortBeginMainFrameBecauseCommitNotNeeded
3) AbortBeginMainFrameAndCancelCommitWhenInvisible -> removed (duplicate of 1.)
4) AbortBeginMainFrameAndRequestCommitWhenInvisible -> removed (duplicate of
TestNoCommitStatesRedrawWhenInvisible and TestRequestCommitInvisible)
When BeginMainFrameAborted is called with **false** it means we **didn't**
attempt a commit. Any pending commits are "not satisfied" and should still be
pending afterwards.
When BeginMainFrameAborted is called with **true** it means we attempted the
commit but there was no work to do. Any pending commits been have been
"satisfied" and should **not** be pending afterwards.
Looking at the code in ThreadProxy::BeginMainFrame method we can confirm this
is the case,
TRACE_EVENT_INSTANT0("cc", "EarlyOut_NotVisible", TRACE_EVENT_SCOPE_THREAD);
Which calls BeginMainFrameAborted(false);
TRACE_EVENT_INSTANT0("cc", "EarlyOut_OutputSurfaceLost", TRACE_EVENT_SCOPE_THREAD);
Which calls BeginMainFrameAborted(false);
TRACE_EVENT_INSTANT0("cc", "EarlyOut_NoUpdates", TRACE_EVENT_SCOPE_THREAD);
Which calls BeginMainFrameAborted(true);
BUG=416749
Committed: https://crrev.com/c1dd0d7dfaaf62367cbdcff1f43cdb5c0ee432ce
Cr-Commit-Position: refs/heads/master@{#308556}
Patch Set 1 #
Messages
Total messages: 10 (4 generated)
|