Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 805843002: cc: Fixing scheduler state machine tests around BeginMainFrameAborted. (Closed)

Created:
6 years ago by mithro-old
Modified:
6 years ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fixing scheduler state machine tests around BeginMainFrameAborted. This CL does the following; 1) TestGoesInvisibleBeforeFinishCommit -> TestAbortBeginMainFrameBecauseInvisible 2) AbortBeginMainFrameAndCancelCommit -> TestAbortBeginMainFrameBecauseCommitNotNeeded 3) AbortBeginMainFrameAndCancelCommitWhenInvisible -> removed (duplicate of 1.) 4) AbortBeginMainFrameAndRequestCommitWhenInvisible -> removed (duplicate of TestNoCommitStatesRedrawWhenInvisible and TestRequestCommitInvisible) When BeginMainFrameAborted is called with **false** it means we **didn't** attempt a commit. Any pending commits are "not satisfied" and should still be pending afterwards. When BeginMainFrameAborted is called with **true** it means we attempted the commit but there was no work to do. Any pending commits been have been "satisfied" and should **not** be pending afterwards. Looking at the code in ThreadProxy::BeginMainFrame method we can confirm this is the case, TRACE_EVENT_INSTANT0("cc", "EarlyOut_NotVisible", TRACE_EVENT_SCOPE_THREAD); Which calls BeginMainFrameAborted(false); TRACE_EVENT_INSTANT0("cc", "EarlyOut_OutputSurfaceLost", TRACE_EVENT_SCOPE_THREAD); Which calls BeginMainFrameAborted(false); TRACE_EVENT_INSTANT0("cc", "EarlyOut_NoUpdates", TRACE_EVENT_SCOPE_THREAD); Which calls BeginMainFrameAborted(true); BUG=416749 Committed: https://crrev.com/c1dd0d7dfaaf62367cbdcff1f43cdb5c0ee432ce Cr-Commit-Position: refs/heads/master@{#308556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -150 lines) Patch
M cc/scheduler/scheduler_state_machine_unittest.cc View 5 chunks +15 lines, -150 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mithro-old
See commit description. This CL is blocking: "cc: Only send a BeginMainFrame inside an BeginImplFrame." ...
6 years ago (2014-12-15 15:52:41 UTC) #2
brianderson
lgtm. Please associate it with a bug.
6 years ago (2014-12-16 02:15:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805843002/1
6 years ago (2014-12-16 06:55:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805843002/1
6 years ago (2014-12-16 08:14:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 08:38:01 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-16 08:41:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1dd0d7dfaaf62367cbdcff1f43cdb5c0ee432ce
Cr-Commit-Position: refs/heads/master@{#308556}

Powered by Google App Engine
This is Rietveld 408576698