Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 831393003: Plumb hasPreciseScrollingDeltas into ScrollGranularity for overflow scrolls. (Closed)

Created:
5 years, 11 months ago by skobes
Modified:
5 years, 11 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, weiliangc, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Plumb hasPreciseScrollingDeltas into ScrollGranularity for overflow scrolls. This will let us re-land http://crrev.com/214953004, which was reverted in http://crbug.com/383946. BUG=575, 417782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188007

Patch Set 1 #

Patch Set 2 : Add a test. #

Total comments: 4

Patch Set 3 : Rebase. #

Patch Set 4 : Address review comments. #

Total comments: 1

Patch Set 5 : Remove testRunner.dumpAsText() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -19 lines) Patch
A LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A + LayoutTests/fast/scroll-behavior/precise-delta-no-animate-expected.txt View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/events/WheelEvent.h View 4 chunks +5 lines, -3 lines 0 comments Download
M Source/core/events/WheelEvent.cpp View 1 4 chunks +5 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 2 chunks +7 lines, -10 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
skobes
5 years, 11 months ago (2015-01-06 01:02:15 UTC) #2
skobes
Notes: - This change parallels what we already do for frame scrolls in ScrollAnimator::handleWheelEvent. - ...
5 years, 11 months ago (2015-01-06 18:59:48 UTC) #3
Rick Byers
Nice. Perhaps worth a simple test case to ensure we'll know if it regresses? The ...
5 years, 11 months ago (2015-01-06 21:27:00 UTC) #4
Rick Byers
On 2015/01/06 21:27:00, Rick Byers wrote: > Nice. Perhaps worth a simple test case to ...
5 years, 11 months ago (2015-01-06 21:27:46 UTC) #5
skobes
On 2015/01/06 21:27:00, Rick Byers wrote: > Nice. Perhaps worth a simple test case to ...
5 years, 11 months ago (2015-01-07 20:25:35 UTC) #6
skobes
+japhet for Source/web
5 years, 11 months ago (2015-01-07 20:26:50 UTC) #8
Rick Byers
On 2015/01/07 20:26:50, skobes wrote: > +japhet for Source/web No longer needed - I added ...
5 years, 11 months ago (2015-01-07 21:51:08 UTC) #9
Rick Byers
LGTM with optional nits https://codereview.chromium.org/831393003/diff/20001/LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html File LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html (right): https://codereview.chromium.org/831393003/diff/20001/LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html#newcode3 LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html:3: <head> Nit: html, head and ...
5 years, 11 months ago (2015-01-07 21:58:13 UTC) #11
skobes
https://codereview.chromium.org/831393003/diff/20001/LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html File LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html (right): https://codereview.chromium.org/831393003/diff/20001/LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html#newcode3 LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html:3: <head> On 2015/01/07 21:58:12, Rick Byers wrote: > Nit: ...
5 years, 11 months ago (2015-01-07 22:05:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831393003/60001
5 years, 11 months ago (2015-01-07 22:05:33 UTC) #14
Rick Byers
https://codereview.chromium.org/831393003/diff/60001/LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html File LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html (right): https://codereview.chromium.org/831393003/diff/60001/LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html#newcode28 LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html:28: testRunner.dumpAsText(); note that this line is also redundant (hence ...
5 years, 11 months ago (2015-01-07 22:10:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831393003/80001
5 years, 11 months ago (2015-01-07 22:14:39 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 23:45:34 UTC) #19
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188007

Powered by Google App Engine
This is Rietveld 408576698