Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 863243004: DM::SKPSrc::size() reports correct size. (Closed)

Created:
5 years, 10 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM::SKPSrc::size() reports correct size. Also: DM::GPUSink and DM::RasterSink crop DM::Src::size() SkPictureData::GetCullRect(SkStream*, SkRect*) function Motivation: Improve PDF testing by printing the entire SKP. BUG=skia:3365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M dm/DMSrcSink.cpp View 5 chunks +15 lines, -7 lines 0 comments Download
M src/core/SkPictureData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hal.canary
ptal
5 years, 10 months ago (2015-01-28 18:21:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863243004/1
5 years, 10 months ago (2015-01-28 18:21:46 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-28 18:21:46 UTC) #5
mtklein
Counterproposal: https://codereview.chromium.org/863243005
5 years, 10 months ago (2015-01-28 19:01:05 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 00:21:50 UTC) #8
No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

Powered by Google App Engine
This is Rietveld 408576698