Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 891523002: ScrollTopLeftInterop should not be marked experimental (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
ajuma
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ScrollTopLeftInterop should not be marked experimental The feature breaks a lot of sites (e.g. those using closure) and it's not clear what the path forward for it is. Until that is clear, we should not mark it as experimental. BUG=426181 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189364

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Patch Set 5 : updates #

Patch Set 6 : updates #

Total comments: 1

Patch Set 7 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -148 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 2 chunks +38 lines, -11 lines 0 comments Download
M LayoutTests/compositing/scissor-out-of-viewport.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/resize-corner-tracking-touch.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/zoom-body-scroll.html View 1 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css/zoom-body-scroll-expected.txt View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/Element/scrollTop-scrollLeft-body.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes.html View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/anchor-without-content.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-fully-scrolled-iframe-propagates.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-fully-scrolled-iframe-propagates-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-editable.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-editable-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-propagated-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-zoomed.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-zoomed-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects-iframe.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects-iframe-fixed.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects-iframe-nested.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/loader/scroll-position-restored-on-back-at-load-event.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/loader/scroll-position-restored-on-back-at-load-event-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/loader/scroll-position-restored-on-reload-at-load-event.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/loader/scroll-position-restored-on-reload-at-load-event-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/scrolling-overflow.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/scrolling-overflow-expected.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/repaint/resources/iframe-scroll-repaint-iframe.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scroll-in-standards-mode-expected.txt View 1 2 3 4 1 chunk +18 lines, -18 lines 0 comments Download
M LayoutTests/fast/scrolling/fractional-scroll-offset-document.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/scrolling/fractional-scroll-offset-document-expected.txt View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M LayoutTests/fast/scrolling/hover-during-scroll.html View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/scrolling/hover-during-scroll-expected.txt View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/navigation/anchor-frames-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigation/anchor-frames-same-origin-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/frame-with-anchor.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/frame-with-anchor-same-origin.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/rubberbanding/scroll-bounce-fix.html View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/InternalSettings.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 3 chunks +7 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
please review. The motivation for this change is that it makes running chrome with experimental ...
5 years, 10 months ago (2015-02-02 13:59:10 UTC) #2
ajuma
On 2015/02/02 13:59:10, jochen (slow) wrote: > please review. > > The motivation for this ...
5 years, 10 months ago (2015-02-02 14:29:38 UTC) #3
ajuma
One question: https://codereview.chromium.org/891523002/diff/100001/LayoutTests/fast/scrolling/hover-during-scroll.html File LayoutTests/fast/scrolling/hover-during-scroll.html (right): https://codereview.chromium.org/891523002/diff/100001/LayoutTests/fast/scrolling/hover-during-scroll.html#newcode41 LayoutTests/fast/scrolling/hover-during-scroll.html:41: shouldBe("document.documentElement.scrollTop", "0"); Does using the body element ...
5 years, 10 months ago (2015-02-02 14:29:53 UTC) #4
jochen (gone - plz use gerrit)
On 2015/02/02 at 14:29:53, ajuma wrote: > One question: > > https://codereview.chromium.org/891523002/diff/100001/LayoutTests/fast/scrolling/hover-during-scroll.html > File LayoutTests/fast/scrolling/hover-during-scroll.html ...
5 years, 10 months ago (2015-02-02 19:45:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891523002/120001
5 years, 10 months ago (2015-02-02 20:31:58 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 21:11:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189364

Powered by Google App Engine
This is Rietveld 408576698