Google Git
Sign in
chromium / chromium / src / 01208718fb14954d7e93da0c900968b8707c3b67
commit01208718fb14954d7e93da0c900968b8707c3b67[log] [tgz]
authorScott Violet <sky@chromium.org>Thu Dec 13 19:11:29 2018
committerCommit Bot <commit-bot@chromium.org>Thu Dec 13 19:11:29 2018
treefb7c1ab2a7efcfac964e1f416f6d3bee1b1ff355
parent62ddb5cf66f3ac65e684d49fe89130253324c644 [diff]
WindowService: makes SetWindowVisibility() return false on failure

In particular, ash has WindowObservers that override OnWindowVisibilityChanged()
and force the window visibility back to what it was. This patch makes the
WindowService deal with this.

BUG=910241
TEST=covered by tests

Change-Id: I4fcd26cd8283aa38ee157f0d9c7831af68e867db
Reviewed-on: https://chromium-review.googlesource.com/c/1375993
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616381}
4 files changed
tree: fb7c1ab2a7efcfac964e1f416f6d3bee1b1ff355
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .