commit | 0174bab48c75e579b8369652e5ed5b4c8dcb11de | [log] [tgz] |
---|---|---|
author | Vasilii Sukhanov <vasilii@chromium.org> | Thu Oct 11 16:56:27 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Oct 11 16:56:27 2018 |
tree | 072934afbb7bfa81744a2d4e145844be95539751 | |
parent | 1c3205982f4b5663301878d2c60a74bf43aee08c [diff] |
Revert "[gin] Allow posting non-nestable tasks through V8" This reverts commit 7f08809af15106c04feb6188b5d54c93af19472b. Reason for revert: broke compilation https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932945363042209344/+/steps/compile/0/stdout ../../gin/v8_foreground_task_runner.h:27:60: error: only virtual member functions can be marked 'override' void PostNonNestableTask(std::unique_ptr<v8::Task> task) override; ^~~~~~~~ ../../gin/v8_foreground_task_runner.h:34:40: error: only virtual member functions can be marked 'override' bool NonNestableTasksEnabled() const override; Original change's description: > [gin] Allow posting non-nestable tasks through V8 > > Will be used to allow V8 posting top-level tasks. > > Bug: chromium:843903 > Change-Id: I97caa705b561fa8832ef8a11abfc3eefe47ec3f8 > Reviewed-on: https://chromium-review.googlesource.com/c/1273140 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598802} TBR=mlippautz@chromium.org,jochen@chromium.org Change-Id: I5d427abfe85e3b69a3d649ee190406a5d9583d9e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:843903 Reviewed-on: https://chromium-review.googlesource.com/c/1277086 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#598804}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .