Google Git
Sign in
chromium / chromium / tools / build / 01c9c6e0e5cf28167a448da46b99efeb2342ce09
commit01c9c6e0e5cf28167a448da46b99efeb2342ce09[log] [tgz]
authorGarrett Beaty <gbeaty@chromium.org>Wed Mar 24 19:05:35 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 24 19:05:35 2021
tree97d81ee66a9b2f5ae9d0910ea2fd76ee7f972226
parentca55e04ab0b60e6d34b7d83cb858591cdf97a8f5 [diff]
Fix blink_web_tests special case handling.

Not all instances of tests with blink_web_tests in the name configure
the layout results handler, so the special case relying on a property
that only exists in that case causes recipe crashes when the layout
results handler is not used.

Bug: 1191240
Change-Id: I7d26f44e561eb8dca8cb383d8034cdd86efb1ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2785071
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
3 files changed
tree: 97d81ee66a9b2f5ae9d0910ea2fd76ee7f972226
  1. infra/
  2. recipes/
  3. scripts/
  4. site_config/
  5. .gitattributes
  6. .gitignore
  7. .style.yapf
  8. .vpython
  9. .yapfignore
  10. codereview.settings
  11. CROS_OWNERS
  12. DEPS
  13. environment.cfg.py
  14. LICENSE
  15. OWNERS
  16. PRESUBMIT.py
  17. README.md
  18. WATCHLISTS
README.md

Recipes

If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.